[PR #12533] [MERGED] thinking: turn on thinking mode for all reasoning models #24404

Closed
opened 2026-04-19 17:33:25 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12533
Author: @pdevine
Created: 10/8/2025
Status: Merged
Merged: 10/8/2025
Merged by: @pdevine

Base: mainHead: pdevine/thinking-on


📝 Commits (4)

  • 7096a8c thinking: turn on thinking mode for all reasoning models
  • 6a34fdf fix unit test and update the openai api compat
  • a6758c1 fix last thinking test
  • 3e54bee feed the linter

📊 Changes

4 files changed (+30 additions, -20 deletions)

View changed files

📝 api/types.go (+1 -1)
📝 openai/openai.go (+11 -6)
📝 server/routes.go (+18 -6)
📝 server/routes_generate_test.go (+0 -7)

📄 Description

This change turns on "thinking" mode for all reasoning models. For models that support it, you can still set "think": false (or "reasoning": false in the case of the /v1/chat/completions API) for models that support turning thinking off.

Supercedes #12520


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12533 **Author:** [@pdevine](https://github.com/pdevine) **Created:** 10/8/2025 **Status:** ✅ Merged **Merged:** 10/8/2025 **Merged by:** [@pdevine](https://github.com/pdevine) **Base:** `main` ← **Head:** `pdevine/thinking-on` --- ### 📝 Commits (4) - [`7096a8c`](https://github.com/ollama/ollama/commit/7096a8c0449e33de8dd2fc0ec8edfd059d6c52c7) thinking: turn on thinking mode for all reasoning models - [`6a34fdf`](https://github.com/ollama/ollama/commit/6a34fdff8f74248bf3ebe40d03489126bcc2c111) fix unit test and update the openai api compat - [`a6758c1`](https://github.com/ollama/ollama/commit/a6758c1234e57da43f31ab587e491513908df170) fix last thinking test - [`3e54bee`](https://github.com/ollama/ollama/commit/3e54bee4df566ddebe312ffbe5e8cab058c31f5b) feed the linter ### 📊 Changes **4 files changed** (+30 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `api/types.go` (+1 -1) 📝 `openai/openai.go` (+11 -6) 📝 `server/routes.go` (+18 -6) 📝 `server/routes_generate_test.go` (+0 -7) </details> ### 📄 Description This change turns on "thinking" mode for all reasoning models. For models that support it, you can still set `"think": false` (or `"reasoning": false` in the case of the `/v1/chat/completions` API) for models that support turning thinking off. Supercedes #12520 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 17:33:25 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#24404