github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-23 14:13:13 -05:00
Code Issues 16.9k Packages Projects Releases 122 Wiki Activity

[PR #11133] server: update model blob and manifest permissions #23990

New Issue
Open
opened 2026-04-19 17:19:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 17:19:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/11133
Author: @LinasVidziunas
Created: 6/19/2025
Status: 🔄 Open

Base: main ← Head: server/models-permissions

📝 Commits (1)

  • d90c362 server: update model blob and manifest permissions

📊 Changes

6 files changed (+23 additions, -14 deletions)

View changed files

📝 server/create.go (+1 -1)
📝 server/download.go (+2 -2)
📝 server/images.go (+3 -3)
📝 server/layer.go (+14 -5)
📝 server/manifest.go (+1 -1)
📝 server/modelpath.go (+2 -2)

📄 Description

This PR updates the permissions for the model blob and manifest files to 666, and directories to 777, before applying umask.

We're using Ollama in a multi-user environment and want to set up a shared models directory to prevent duplicate downloads. Currently, model files (644) and directories (755) restrict sharing, regardless of umask. With this change, setting a permissive umask (e.g., 000) allows all users to read/write shared models, while the default umask (022) keeps the existing behavior.

Thank you for reviewing this PR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/11133 **Author:** [@LinasVidziunas](https://github.com/LinasVidziunas) **Created:** 6/19/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `server/models-permissions` --- ### 📝 Commits (1) - [`d90c362`](https://github.com/ollama/ollama/commit/d90c362e700b0beda3bda9450ff687e5e81cd535) server: update model blob and manifest permissions ### 📊 Changes **6 files changed** (+23 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `server/create.go` (+1 -1) 📝 `server/download.go` (+2 -2) 📝 `server/images.go` (+3 -3) 📝 `server/layer.go` (+14 -5) 📝 `server/manifest.go` (+1 -1) 📝 `server/modelpath.go` (+2 -2) </details> ### 📄 Description This PR updates the permissions for the model blob and manifest files to 666, and directories to 777, before applying umask. We're using Ollama in a multi-user environment and want to set up a shared models directory to prevent duplicate downloads. Currently, model files (644) and directories (755) restrict sharing, regardless of umask. With this change, setting a permissive umask (e.g., 000) allows all users to read/write shared models, while the default umask (022) keeps the existing behavior. Thank you for reviewing this PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 17:19:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#23990
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?