github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-23 22:21:55 -05:00
Code Issues 16.9k Packages Projects Releases 122 Wiki Activity

[PR #10917] [MERGED] tools: resiliency upgrade to name and arg extraction from template #23937

New Issue
Closed
opened 2026-04-19 17:17:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 17:17:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/10917
Author: @ParthSareen
Created: 5/30/2025
Status: ✅ Merged
Merged: 5/30/2025
Merged by: @ParthSareen

Base: main ← Head: parth/tools-fix-json-args-template

📝 Commits (1)

  • ea0ce4b tools: resiliency upgrade to name and arg extraction from template

📊 Changes

2 files changed (+97 additions, -69 deletions)

View changed files

📝 tools/tools_utils.go (+15 -20)
📝 tools/tools_utils_test.go (+82 -49)

📄 Description

Closes: https://github.com/ollama/ollama/issues/10897

Doesn't fully solve the issue as an extra token gets printed out but at least gets it to working state.

<tool_call>

Calling function: get_temperature
Arguments:
{'city': 'Tokyo'}
Function output: 30

Update:

  • strip out the <tool_call> stuff when in FC

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/10917 **Author:** [@ParthSareen](https://github.com/ParthSareen) **Created:** 5/30/2025 **Status:** ✅ Merged **Merged:** 5/30/2025 **Merged by:** [@ParthSareen](https://github.com/ParthSareen) **Base:** `main` ← **Head:** `parth/tools-fix-json-args-template` --- ### 📝 Commits (1) - [`ea0ce4b`](https://github.com/ollama/ollama/commit/ea0ce4bcf9c214755a0fffc23225bf7432302e47) tools: resiliency upgrade to name and arg extraction from template ### 📊 Changes **2 files changed** (+97 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `tools/tools_utils.go` (+15 -20) 📝 `tools/tools_utils_test.go` (+82 -49) </details> ### 📄 Description Closes: https://github.com/ollama/ollama/issues/10897 Doesn't fully solve the issue as an extra token gets printed out but at least gets it to working state. ```Prompt: What is the temperature in Tokyo? <tool_call> Calling function: get_temperature Arguments: {'city': 'Tokyo'} Function output: 30 ``` Update: - [ ] strip out the <tool_call> stuff when in FC --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 17:17:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#23937
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?