github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-08 08:59:13 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #10710] [MERGED] fix crash in old clients with quantization progress #23876

New Issue
Closed
opened 2026-04-19 17:16:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 17:16:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/10710
Author: @dhiltgen
Created: 5/14/2025
Status: ✅ Merged
Merged: 5/14/2025
Merged by: @dhiltgen

Base: main ← Head: ggml_quant

📝 Commits (1)

  • d883150 fix crash in old clients with quantization progress

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/create.go (+1 -1)

📄 Description

Older clients assumed the digest was at least 19 characters long so increase the size of the dummy digest to avoid array out of bounds crashes.

The progress output will be a bit misleading (it isn't pulling but quantizing), but the old clients wont crash now:

% ollama create test-maybe -f ./test.modelfile -q Q4_K_M
gathering model components
pulling 000000000000... 100% ▕████████████████████████████████████████████████████████████ ▏ 6.4 GB/6.4 GB  464 MB/s      0s
verifying conversion
using existing layer sha256:fb7f4f211b89c6c4928ff4ddb73db9f9c0cfca3e000c3e40d6cf27ddc6ca72eb
using existing layer sha256:966de95ca8a62200913e3f8bfbf84c8494536f1b94b49166851e76644e966396
using existing layer sha256:fcc5a6bec9daf9b561a68827b67ab6088e1dba9d1fa2a50d7bbcc8384e0a265d
using existing layer sha256:a70ff7e570d97baaf4e62ac6e6ad9975e04caa6d900d3742d37698494479e0cd
using existing layer sha256:56bb8bd477a519ffa694fc449c2413c6f0e1d3b1c88fa7e3c9d88d3ae49d4dcb
writing manifest
success

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/10710 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 5/14/2025 **Status:** ✅ Merged **Merged:** 5/14/2025 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `ggml_quant` --- ### 📝 Commits (1) - [`d883150`](https://github.com/ollama/ollama/commit/d883150f6a56040cc6bd1e5892bd1d6de6c9a622) fix crash in old clients with quantization progress ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/create.go` (+1 -1) </details> ### 📄 Description Older clients assumed the digest was at least 19 characters long so increase the size of the dummy digest to avoid array out of bounds crashes. The progress output will be a bit misleading (it isn't pulling but quantizing), but the old clients wont crash now: ``` % ollama create test-maybe -f ./test.modelfile -q Q4_K_M gathering model components pulling 000000000000... 100% ▕████████████████████████████████████████████████████████████ ▏ 6.4 GB/6.4 GB 464 MB/s 0s verifying conversion using existing layer sha256:fb7f4f211b89c6c4928ff4ddb73db9f9c0cfca3e000c3e40d6cf27ddc6ca72eb using existing layer sha256:966de95ca8a62200913e3f8bfbf84c8494536f1b94b49166851e76644e966396 using existing layer sha256:fcc5a6bec9daf9b561a68827b67ab6088e1dba9d1fa2a50d7bbcc8384e0a265d using existing layer sha256:a70ff7e570d97baaf4e62ac6e6ad9975e04caa6d900d3742d37698494479e0cd using existing layer sha256:56bb8bd477a519ffa694fc449c2413c6f0e1d3b1c88fa7e3c9d88d3ae49d4dcb writing manifest success ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 17:16:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#23876
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?