github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 08:30:05 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #9324] [MERGED] llm: remove internal subprocess req and resp types #23457

New Issue
Closed
opened 2026-04-19 17:00:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 17:00:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/9324
Author: @BruceMacD
Created: 2/24/2025
Status: ✅ Merged
Merged: 3/14/2025
Merged by: @BruceMacD

Base: main ← Head: brucemacd/server-types

📝 Commits (3)

📊 Changes

4 files changed (+125 additions, -354 deletions)

View changed files

📝 llm/server.go (+39 -97)
📝 runner/llamarunner/runner.go (+50 -135)
📝 runner/ollamarunner/cache.go (+1 -0)
📝 runner/ollamarunner/runner.go (+35 -122)

📄 Description

As mentioned in #9282

This commit refactors the LLM subsystem by removing internal subprocess request and response types. It consolidates duplicate type definitions across the codebase, moving them to centralized locations. The change also standardizes interfaces between components, simplifies the ServerStatusResp struct (removing unused fields), and moves the ParseDurationMs function to a common package. This cleanup reduces code duplication between different runner implementations (llamarunner and ollamarunner).

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/9324 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 2/24/2025 **Status:** ✅ Merged **Merged:** 3/14/2025 **Merged by:** [@BruceMacD](https://github.com/BruceMacD) **Base:** `main` ← **Head:** `brucemacd/server-types` --- ### 📝 Commits (3) - [`92555cf`](https://github.com/ollama/ollama/commit/92555cf528ec10f5a0852783a47ec5d5bf58957a) llm: remove internal subprocess req and resp types - [`c571df6`](https://github.com/ollama/ollama/commit/c571df6521cf1705d76311fe7ca3f9b27854b096) pr feedback - [`ed175c8`](https://github.com/ollama/ollama/commit/ed175c821361e0ea069bb449899fd0e8ee263959) pr feedback ### 📊 Changes **4 files changed** (+125 additions, -354 deletions) <details> <summary>View changed files</summary> 📝 `llm/server.go` (+39 -97) 📝 `runner/llamarunner/runner.go` (+50 -135) 📝 `runner/ollamarunner/cache.go` (+1 -0) 📝 `runner/ollamarunner/runner.go` (+35 -122) </details> ### 📄 Description As mentioned in #9282 This commit refactors the LLM subsystem by removing internal subprocess request and response types. It consolidates duplicate type definitions across the codebase, moving them to centralized locations. The change also standardizes interfaces between components, simplifies the `ServerStatusResp` struct (removing unused fields), and moves the `ParseDurationMs` function to a common package. This cleanup reduces code duplication between different runner implementations (llamarunner and ollamarunner). <img width="694" alt="image" src="https://github.com/user-attachments/assets/7e3386e5-27ad-483c-8f5b-37b185727136" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 17:00:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#23457
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?