github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 08:30:05 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #8957] [CLOSED] feat: add debug logging in chat/generate functions #23367

New Issue
Closed
opened 2026-04-19 16:56:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 16:56:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/8957
Author: @mateuszdrab
Created: 2/9/2025
Status: ❌ Closed

Base: main ← Head: response-debug-log

📝 Commits (3)

  • 7a1b159 feat: add debug logging for response generation in GenerateHandler and ChatHandler
  • 7a8c8c4 Fix tap to spaces in line 1496
  • 9056c56 Merge branch 'main' into response-debug-log

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 server/routes.go (+11 -0)

📄 Description

This small PR adds debug logging to the GenerateHandler and ChatHandler functions comprehending the already existing chat/generate request logging.

There appear to be two places where logging could be added, however, with the placement of the debug log function calls as of now, it works for me with both streaming and non-streaming responses.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/8957 **Author:** [@mateuszdrab](https://github.com/mateuszdrab) **Created:** 2/9/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `response-debug-log` --- ### 📝 Commits (3) - [`7a1b159`](https://github.com/ollama/ollama/commit/7a1b159bceab12f819a9d42eb0819f6953e02d3e) feat: add debug logging for response generation in GenerateHandler and ChatHandler - [`7a8c8c4`](https://github.com/ollama/ollama/commit/7a8c8c4c885bc53850656116d5fe76eced2fccca) Fix tap to spaces in line 1496 - [`9056c56`](https://github.com/ollama/ollama/commit/9056c5684a2a1a96a285901584fa84fd633fd03b) Merge branch 'main' into response-debug-log ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/routes.go` (+11 -0) </details> ### 📄 Description This small PR adds debug logging to the `GenerateHandler` and `ChatHandler` functions comprehending the already existing chat/generate request logging. There appear to be two places where logging could be added, however, with the placement of the debug log function calls as of now, it works for me with both streaming and non-streaming responses. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 16:56:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#23367
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?