github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #8232] [CLOSED] Remove redundant image_url format check in fromChatRequest #23212

New Issue
Closed
opened 2026-04-19 16:50:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 16:50:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/8232
Author: @muzzlol
Created: 12/24/2024
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (2)

  • 2fe92ca openai: remove redundant image_url format check in fromChatRequest
  • b7eea92 Merge remote-tracking branch 'upstream/main'

📊 Changes

1 file changed (+8 additions, -8 deletions)

View changed files

📝 openai/openai.go (+8 -8)

📄 Description

Improves the fromChatRequest function by removing redundant checks for Ollama's direct string format and improving error messages for better debugging.

Summary of changes:

  • Removed the redundant check for image_url in Ollama format.
  • Clarified and enhanced error messages in the conversion logic.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/8232 **Author:** [@muzzlol](https://github.com/muzzlol) **Created:** 12/24/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`2fe92ca`](https://github.com/ollama/ollama/commit/2fe92ca113ee95e60004d2781746d7cdfe7ee565) openai: remove redundant image_url format check in fromChatRequest - [`b7eea92`](https://github.com/ollama/ollama/commit/b7eea9229316048b6be6e07136498180d61579bc) Merge remote-tracking branch 'upstream/main' ### 📊 Changes **1 file changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `openai/openai.go` (+8 -8) </details> ### 📄 Description Improves the `fromChatRequest` function by removing redundant checks for Ollama's direct string format and improving error messages for better debugging. Summary of changes: - Removed the redundant check for `image_url` in Ollama format. - Clarified and enhanced error messages in the conversion logic. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 16:50:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#23212
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?