github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #5018] [CLOSED] fix utf8 parser error #22182

New Issue
Closed
opened 2026-04-19 16:08:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 16:08:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/5018
Author: @007gzs
Created: 6/13/2024
Status: ❌ Closed

Base: main ← Head: patch-1

📝 Commits (2)

📊 Changes

2 files changed (+13 additions, -1 deletions)

View changed files

📝 parser/parser.go (+2 -1)
📝 parser/parser_test.go (+11 -0)

📄 Description

in v0.1.43 when utf8 char in modelfile ,after parse got �������������

test code :

	var Modelfile string = "FROM llama3:70b\nSYSTEM \"\"\"\n提问和回答都使用中文\n\"\"\""
	var sr io.Reader = strings.NewReader(Modelfile)
	f, err := parser.ParseFile(sr)
	fmt.Printf("err: %v\n", err)
	fmt.Printf("f: %v\n", f)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/5018 **Author:** [@007gzs](https://github.com/007gzs) **Created:** 6/13/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`08ebacb`](https://github.com/ollama/ollama/commit/08ebacb8c4da4432a85ddf97fde9365bfc47b5b2) fix utf8 parser error - [`d22cec1`](https://github.com/ollama/ollama/commit/d22cec1c1f2eb62b740f64cabd0b658073b78ffe) add utf8 test case ### 📊 Changes **2 files changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `parser/parser.go` (+2 -1) 📝 `parser/parser_test.go` (+11 -0) </details> ### 📄 Description in `v0.1.43` when utf8 char in modelfile ,after parse got `�������������` test code : ``` var Modelfile string = "FROM llama3:70b\nSYSTEM \"\"\"\n提问和回答都使用中文\n\"\"\"" var sr io.Reader = strings.NewReader(Modelfile) f, err := parser.ParseFile(sr) fmt.Printf("err: %v\n", err) fmt.Printf("f: %v\n", f) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 16:08:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#22182
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?