github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 16:40:08 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15001] fix: exit on critical sudo failures in install.sh #20233

New Issue
Open
opened 2026-04-16 07:30:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 07:30:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15001
Author: @alvinttang
Created: 3/22/2026
Status: 🔄 Open

Base: main ← Head: fix/exit-on-sudo-failure

📝 Commits (1)

  • ba71a87 fix: exit on critical sudo failures in install.sh

📊 Changes

1 file changed (+26 additions, -8 deletions)

View changed files

📝 scripts/install.sh (+26 -8)

📄 Description

Summary

  • Fixes the install.sh script silently reporting "Install complete" even when critical sudo commands fail (e.g., sudo timeout, wrong password)
  • Adds explicit || error "..." checks after each critical sudo command in configure_systemd(): useradd, usermod, tee (service file), systemctl daemon-reload, systemctl enable, and systemctl restart
  • Makes the install_success EXIT trap check the exit code ($?) so it does not print a false success message when the script exits due to a prior failure

Fixes #14998

Test plan

  • Run install.sh normally on a Linux system with systemd — verify it completes successfully and prints "Install complete"
  • Run install.sh and let the sudo password prompt time out — verify the script exits with an error message instead of "Install complete"
  • Run install.sh on a system without systemd — verify it still works (the configure_systemd path is skipped)
  • Run sh -n scripts/install.sh to confirm no syntax errors

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15001 **Author:** [@alvinttang](https://github.com/alvinttang) **Created:** 3/22/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/exit-on-sudo-failure` --- ### 📝 Commits (1) - [`ba71a87`](https://github.com/ollama/ollama/commit/ba71a8757faba4f6f8857e3f5fe5f96463018238) fix: exit on critical sudo failures in install.sh ### 📊 Changes **1 file changed** (+26 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `scripts/install.sh` (+26 -8) </details> ### 📄 Description ## Summary - Fixes the `install.sh` script silently reporting "Install complete" even when critical `sudo` commands fail (e.g., sudo timeout, wrong password) - Adds explicit `|| error "..."` checks after each critical sudo command in `configure_systemd()`: `useradd`, `usermod`, `tee` (service file), `systemctl daemon-reload`, `systemctl enable`, and `systemctl restart` - Makes the `install_success` EXIT trap check the exit code (`$?`) so it does not print a false success message when the script exits due to a prior failure Fixes #14998 ## Test plan - [ ] Run `install.sh` normally on a Linux system with systemd — verify it completes successfully and prints "Install complete" - [ ] Run `install.sh` and let the sudo password prompt time out — verify the script exits with an error message instead of "Install complete" - [ ] Run `install.sh` on a system without systemd — verify it still works (the `configure_systemd` path is skipped) - [ ] Run `sh -n scripts/install.sh` to confirm no syntax errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 07:30:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#20233
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?