github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14987] fix: use fallback hostname when os.Hostname() fails #20225

New Issue
Open
opened 2026-04-16 07:30:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 07:30:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14987
Author: @JasonOA888
Created: 3/21/2026
Status: 🔄 Open

Base: main ← Head: fix/hostname-fallback-with-warning

📝 Commits (1)

  • 4a07bb7 fix: use fallback hostname when os.Hostname() fails

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 server/routes.go (+5 -1)

📄 Description

Summary

Fixes #14956

Per @guicybercode feedback on #14975, this version adds a warning log when the fallback triggers.

Changes

  • Capture the error from os.Hostname()
  • Log a warning with slog.Warn() when hostname cannot be determined
  • Use "unknown" as fallback value
  • This allows operators to detect when os.Hostname() fails, which usually indicates a deeper system misconfiguration

Example Log Output

WARN os.Hostname() failed, using fallback error="gethostname: hostname too long"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14987 **Author:** [@JasonOA888](https://github.com/JasonOA888) **Created:** 3/21/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/hostname-fallback-with-warning` --- ### 📝 Commits (1) - [`4a07bb7`](https://github.com/ollama/ollama/commit/4a07bb785d9cba24b2eb27f594be49909012f2a7) fix: use fallback hostname when os.Hostname() fails ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/routes.go` (+5 -1) </details> ### 📄 Description ## Summary Fixes #14956 Per @guicybercode feedback on #14975, this version adds a warning log when the fallback triggers. ## Changes - Capture the error from `os.Hostname()` - Log a warning with `slog.Warn()` when hostname cannot be determined - Use `"unknown"` as fallback value - This allows operators to detect when `os.Hostname()` fails, which usually indicates a deeper system misconfiguration ## Example Log Output ``` WARN os.Hostname() failed, using fallback error="gethostname: hostname too long" ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 07:30:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#20225
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?