github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14451] [MERGED] fix: window app crash on startup when update is pending #19947

New Issue
Closed
opened 2026-04-16 07:21:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 07:21:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14451
Author: @hoyyeva
Created: 2/26/2026
Status: ✅ Merged
Merged: 2/26/2026
Merged by: @hoyyeva

Base: main ← Head: fix/windows-update-nil-tray

📝 Commits (2)

  • 641ab53 fix: window app crash on startup when update is pending
  • f498ac2 app: skip updateavailable call on windows

📊 Changes

2 files changed (+21 additions, -2 deletions)

View changed files

📝 app/cmd/app/app.go (+9 -2)
📝 app/cmd/app/app_windows.go (+12 -0)

📄 Description

Summary

  • Fix nil pointer dereference panic on Windows when the app starts with a
    pending update
  • Add nil guard to UpdateAvailable to prevent crash when tray is not yet
    initialized
  • Re-check for pending updates inside osRun after the tray is initialized

Fixes #14450

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14451 **Author:** [@hoyyeva](https://github.com/hoyyeva) **Created:** 2/26/2026 **Status:** ✅ Merged **Merged:** 2/26/2026 **Merged by:** [@hoyyeva](https://github.com/hoyyeva) **Base:** `main` ← **Head:** `fix/windows-update-nil-tray` --- ### 📝 Commits (2) - [`641ab53`](https://github.com/ollama/ollama/commit/641ab53504f30176d05dd45cae896f5835fcd2ea) fix: window app crash on startup when update is pending - [`f498ac2`](https://github.com/ollama/ollama/commit/f498ac279e981fc5576cbb721d682d148d999a1d) app: skip updateavailable call on windows ### 📊 Changes **2 files changed** (+21 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/cmd/app/app.go` (+9 -2) 📝 `app/cmd/app/app_windows.go` (+12 -0) </details> ### 📄 Description **Summary** - Fix nil pointer dereference panic on Windows when the app starts with a pending update - Add nil guard to UpdateAvailable to prevent crash when tray is not yet initialized - Re-check for pending updates inside osRun after the tray is initialized Fixes #14450 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 07:21:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#19947
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?