github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #13059] [CLOSED] Fix single directory selector #19325

New Issue
Closed
opened 2026-04-16 07:04:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 07:04:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/13059
Author: @levystar
Created: 11/12/2025
Status: ❌ Closed

Base: main ← Head: patch-1

📝 Commits (2)

  • 18f3b17 Fix single directory selector
  • 42b7312 Style fix in conditional statement

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/dialog/cocoa/dlg.m (+1 -1)

📄 Description

app: fix singledirectory selection returning empty path.

Fixed a bug in the Cocoa dialog implementation where single directory
selection was not writing the selected path to the output buffer, causing
directory selection dialogs to always return empty strings to JavaScript
callbacks despite successful user selection.
Added the single file case to the existing code by eliminating the check of select multiple.

Fix Issue #12883

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/13059 **Author:** [@levystar](https://github.com/levystar) **Created:** 11/12/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`18f3b17`](https://github.com/ollama/ollama/commit/18f3b17dbc631d458efa4d50b04993354653438f) Fix single directory selector - [`42b7312`](https://github.com/ollama/ollama/commit/42b7312d1774e525b6a65c2f50daabe2fe435874) Style fix in conditional statement ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/dialog/cocoa/dlg.m` (+1 -1) </details> ### 📄 Description app: fix singledirectory selection returning empty path. Fixed a bug in the Cocoa dialog implementation where single directory selection was not writing the selected path to the output buffer, causing directory selection dialogs to always return empty strings to JavaScript callbacks despite successful user selection. Added the single file case to the existing code by eliminating the check of select multiple. Fix Issue #12883 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 07:04:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#19325
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?