github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-07-15 20:54:54 -05:00
Code Issues 16.9k Packages Projects Releases 122 Wiki Activity

[PR #10639] [MERGED] feat: handle ml.DumpOptions better #18577

New Issue
Closed
opened 2026-04-16 06:39:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 06:39:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/10639
Author: @mxyng
Created: 5/9/2025
Status: ✅ Merged
Merged: 5/10/2025
Merged by: @mxyng

Base: main ← Head: mxyng/dump-options

📝 Commits (1)

  • 2b2a0d2 feat: add threshold to dump options

📊 Changes

1 file changed (+40 additions, -16 deletions)

View changed files

📝 ml/backend.go (+40 -16)

📄 Description

ml.Dump will preserve default values if not specified. previously, if you provide any value for opts, it will override the defaults

Example:

Dump(ctx, t) // => precision=4, edgeitems=3

Example: set precision

Dump(ctx, t, DumpWithPrecision(6)) // => precision=6, edgeitems=3

Example: set edgeitems

Dump(ctx, t, DumpWithEdgeItems(4)) // => precision=4, edgeitems=3

Example: set both precision and edgeitems

Dump(ctx, t, DumpWithPrecision(6), DumpWithEdgeItems(4)) // => precision=6, edgeitems=4

This change also adds a Threshold field where the full tensor will be dumped if the total number of items is less than or equal to Threshold

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/10639 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 5/9/2025 **Status:** ✅ Merged **Merged:** 5/10/2025 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/dump-options` --- ### 📝 Commits (1) - [`2b2a0d2`](https://github.com/ollama/ollama/commit/2b2a0d2308fdfba626cc65e844be43c29e1ba440) feat: add threshold to dump options ### 📊 Changes **1 file changed** (+40 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `ml/backend.go` (+40 -16) </details> ### 📄 Description `ml.Dump` will preserve default values if not specified. previously, if you provide any value for `opts`, it will override the defaults Example: ```go Dump(ctx, t) // => precision=4, edgeitems=3 ``` Example: set precision ```go Dump(ctx, t, DumpWithPrecision(6)) // => precision=6, edgeitems=3 ``` Example: set edgeitems ```go Dump(ctx, t, DumpWithEdgeItems(4)) // => precision=4, edgeitems=3 ``` Example: set both precision and edgeitems ```go Dump(ctx, t, DumpWithPrecision(6), DumpWithEdgeItems(4)) // => precision=6, edgeitems=4 ``` This change also adds a `Threshold` field where the full tensor will be dumped if the total number of items is less than or equal to `Threshold` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 06:39:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#18577
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?