github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 16:40:08 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #10540] [MERGED] ollamarunner: Re-enable worst case graph preallocation. #18541

New Issue
Closed
opened 2026-04-16 06:38:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 06:38:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/10540
Author: @jessegross
Created: 5/2/2025
Status: ✅ Merged
Merged: 5/2/2025
Merged by: @jessegross

Base: main ← Head: jessegross/talloc

📝 Commits (1)

  • 2ed1140 ollamarunner: Re-enable worst case graph preallocation.

📊 Changes

3 files changed (+46 additions, -7 deletions)

View changed files

➕ llama/patches/0018-ggml-Don-t-assert-fail-when-tensor-data-changes-1322.patch (+38 -0)
📝 ml/backend/ggml/ggml/src/ggml-alloc.c (+4 -1)
📝 runner/ollamarunner/runner.go (+4 -6)

📄 Description

Worst case graph preallocation was disabled by a27462b "ollamarunner: Temporarily disable worst case graph preallocation" since it caused crashes with large batches when not using the GPU.

This backports upstream llama.cpp commit f057808
"ggml: Don't assert fail when tensor data changes (#13222)", which fixes the underlying bug and allows reverting the previous workaround.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/10540 **Author:** [@jessegross](https://github.com/jessegross) **Created:** 5/2/2025 **Status:** ✅ Merged **Merged:** 5/2/2025 **Merged by:** [@jessegross](https://github.com/jessegross) **Base:** `main` ← **Head:** `jessegross/talloc` --- ### 📝 Commits (1) - [`2ed1140`](https://github.com/ollama/ollama/commit/2ed114085625ee29c5b041194cf1fc8f908999a2) ollamarunner: Re-enable worst case graph preallocation. ### 📊 Changes **3 files changed** (+46 additions, -7 deletions) <details> <summary>View changed files</summary> ➕ `llama/patches/0018-ggml-Don-t-assert-fail-when-tensor-data-changes-1322.patch` (+38 -0) 📝 `ml/backend/ggml/ggml/src/ggml-alloc.c` (+4 -1) 📝 `runner/ollamarunner/runner.go` (+4 -6) </details> ### 📄 Description Worst case graph preallocation was disabled by a27462b "ollamarunner: Temporarily disable worst case graph preallocation" since it caused crashes with large batches when not using the GPU. This backports upstream llama.cpp commit f057808 "ggml: Don't assert fail when tensor data changes (#13222)", which fixes the underlying bug and allows reverting the previous workaround. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 06:38:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#18541
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?