github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #8428] [MERGED] Fix absolute path names + gguf detection #17977

New Issue
Closed
opened 2026-04-16 06:21:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 06:21:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/8428
Author: @pdevine
Created: 1/14/2025
Status: ✅ Merged
Merged: 1/15/2025
Merged by: @pdevine

Base: main ← Head: pdevine/create-abs

📝 Commits (7)

📊 Changes

4 files changed (+217 additions, -28 deletions)

View changed files

📝 parser/expandpath_test.go (+89 -25)
📝 parser/parser.go (+3 -1)
📝 server/create.go (+27 -2)
📝 server/routes_create_test.go (+98 -0)

📄 Description

This change fixes two issues with the model creation:

  1. Absolute pathnames for GGUF files were being treated as a relative pathname; and
  2. The GGUF image detection wasn't able to correctly determine if a GGUF file w/o the correct extension was actually a GGUF file.

This change fixes both issues and adds additional unit tests.

Fixes #8427 and #8423

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/8428 **Author:** [@pdevine](https://github.com/pdevine) **Created:** 1/14/2025 **Status:** ✅ Merged **Merged:** 1/15/2025 **Merged by:** [@pdevine](https://github.com/pdevine) **Base:** `main` ← **Head:** `pdevine/create-abs` --- ### 📝 Commits (7) - [`dcdbb10`](https://github.com/ollama/ollama/commit/dcdbb102b748e78eb7e4bc686c7b0ae3fabef59b) fix absolute path / gguf detection - [`cf4dd80`](https://github.com/ollama/ollama/commit/cf4dd807581a8ba66f60ccde50bdbcafce1d819f) add tests - [`5fde175`](https://github.com/ollama/ollama/commit/5fde175eb471d0c18c3ba8c9d06d72c7d9eb7559) address comments - [`7184d53`](https://github.com/ollama/ollama/commit/7184d538ebdf15d72db394fbc48e50bc6bc77978) gofumpt the code - [`e080b2b`](https://github.com/ollama/ollama/commit/e080b2bf32b7ea690f7ff2b94527fb9b457ba798) more windows excitement - [`ee5310f`](https://github.com/ollama/ollama/commit/ee5310f60d2fbd9d14f097321d2b91765a533208) more windows test fixes - [`098bf90`](https://github.com/ollama/ollama/commit/098bf90843f6ee8249fb52885333e35336b9729a) fix linter ### 📊 Changes **4 files changed** (+217 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `parser/expandpath_test.go` (+89 -25) 📝 `parser/parser.go` (+3 -1) 📝 `server/create.go` (+27 -2) 📝 `server/routes_create_test.go` (+98 -0) </details> ### 📄 Description This change fixes two issues with the model creation: 1. Absolute pathnames for GGUF files were being treated as a relative pathname; and 2. The GGUF image detection wasn't able to correctly determine if a GGUF file w/o the correct extension was actually a GGUF file. This change fixes both issues and adds additional unit tests. Fixes #8427 and #8423 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 06:21:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#17977
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?