github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 08:02:14 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #8052] [MERGED] ci: fix artifact path prefix for missing windows payloads #17875

New Issue
Closed
opened 2026-04-16 06:17:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 06:17:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/8052
Author: @dhiltgen
Created: 12/11/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @dhiltgen

Base: main ← Head: ci_fix

📝 Commits (1)

  • aad3efc ci: fix artifact path prefix for missing windows payloads

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 .github/workflows/release.yaml (+4 -0)

📄 Description

upload-artifacts strips off leading common paths so when the ./build/ artifacts were removed, the ./dist/windows-amd64 prefix became common and was stripped, making the
later download-artifacts place them in the wrong location

Example intermediate artifact from before the build changes:

% unzip generate-windows-cuda-11.3.zip
Archive:  generate-windows-cuda-11.3.zip
  inflating: build/darwin/amd64/placeholder
  inflating: build/darwin/arm64/placeholder
  inflating: build/embed_darwin_amd64.go
  inflating: build/embed_darwin_arm64.go
  inflating: build/embed_linux.go
  inflating: build/embed_unused.go
  inflating: build/linux/amd64/placeholder
  inflating: build/linux/arm64/placeholder
  inflating: dist/windows-amd64/lib/ollama/cublas64_11.dll
  inflating: dist/windows-amd64/lib/ollama/cudart32_110.dll
  inflating: dist/windows-amd64/lib/ollama/cublasLt64_11.dll
  inflating: dist/windows-amd64/lib/ollama/cudart64_110.dll
  inflating: dist/windows-amd64/lib/ollama/ggml_cuda_v11.dll
  inflating: dist/windows-amd64/lib/ollama/runners/cuda_v11/ollama_llama_server.exe

Example artifact now:

% unzip generate-windows-cuda-11.3.zip
Archive:  generate-windows-cuda-11.3.zip
  inflating: lib/ollama/cublas64_11.dll
  inflating: lib/ollama/cublasLt64_11.dll
  inflating: lib/ollama/cudart64_110.dll
  inflating: lib/ollama/cudart32_110.dll
  inflating: lib/ollama/runners/cuda_v11_avx/ggml_cuda_v11.dll
  inflating: lib/ollama/runners/cuda_v11_avx/ollama_llama_server.exe

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/8052 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 12/11/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `ci_fix` --- ### 📝 Commits (1) - [`aad3efc`](https://github.com/ollama/ollama/commit/aad3efc20bb462e31fd3c4b6ae3a304fbe7cab04) ci: fix artifact path prefix for missing windows payloads ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yaml` (+4 -0) </details> ### 📄 Description upload-artifacts strips off leading common paths so when the ./build/ artifacts were removed, the ./dist/windows-amd64 prefix became common and was stripped, making the later download-artifacts place them in the wrong location Example intermediate artifact from before the build changes: ``` % unzip generate-windows-cuda-11.3.zip Archive: generate-windows-cuda-11.3.zip inflating: build/darwin/amd64/placeholder inflating: build/darwin/arm64/placeholder inflating: build/embed_darwin_amd64.go inflating: build/embed_darwin_arm64.go inflating: build/embed_linux.go inflating: build/embed_unused.go inflating: build/linux/amd64/placeholder inflating: build/linux/arm64/placeholder inflating: dist/windows-amd64/lib/ollama/cublas64_11.dll inflating: dist/windows-amd64/lib/ollama/cudart32_110.dll inflating: dist/windows-amd64/lib/ollama/cublasLt64_11.dll inflating: dist/windows-amd64/lib/ollama/cudart64_110.dll inflating: dist/windows-amd64/lib/ollama/ggml_cuda_v11.dll inflating: dist/windows-amd64/lib/ollama/runners/cuda_v11/ollama_llama_server.exe ``` Example artifact now: ``` % unzip generate-windows-cuda-11.3.zip Archive: generate-windows-cuda-11.3.zip inflating: lib/ollama/cublas64_11.dll inflating: lib/ollama/cublasLt64_11.dll inflating: lib/ollama/cudart64_110.dll inflating: lib/ollama/cudart32_110.dll inflating: lib/ollama/runners/cuda_v11_avx/ggml_cuda_v11.dll inflating: lib/ollama/runners/cuda_v11_avx/ollama_llama_server.exe ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 06:17:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#17875
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?