github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 08:02:14 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #7676] [MERGED] server: allow mixed-case model names on push, pull, cp, and create #17756

New Issue
Closed
opened 2026-04-16 06:13:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 06:13:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/7676
Author: @bmizerany
Created: 11/15/2024
Status: ✅ Merged
Merged: 11/19/2024
Merged by: @bmizerany

Base: main ← Head: bmizerany/mixedcasepullsandpushes

📝 Commits (1)

  • 89ca38a server: allow mixed-case model names on push, pull, cp, and create

📊 Changes

4 files changed (+163 additions, -78 deletions)

View changed files

📝 server/images.go (+19 -0)
📝 server/routes.go (+21 -13)
📝 server/routes_test.go (+116 -65)
📝 types/model/name.go (+7 -0)

📄 Description

This change allows for mixed-case model names to be pushed, pulled, copied, and created, which was previously disallowed because the Ollama registry was backed by a Docker registry that enforced a naming convention that disallowed mixed-case names, which is no longer the case.

This does not break existing, intended, behaviors.

Also, make TestCase test a story of creating, updating, pulling, and copying a model with case variations, ensuring the model's manifest is updated correctly, and not duplicated across different files with different case variations.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/7676 **Author:** [@bmizerany](https://github.com/bmizerany) **Created:** 11/15/2024 **Status:** ✅ Merged **Merged:** 11/19/2024 **Merged by:** [@bmizerany](https://github.com/bmizerany) **Base:** `main` ← **Head:** `bmizerany/mixedcasepullsandpushes` --- ### 📝 Commits (1) - [`89ca38a`](https://github.com/ollama/ollama/commit/89ca38a69bce86233a402f6a5f2d03492c11435d) server: allow mixed-case model names on push, pull, cp, and create ### 📊 Changes **4 files changed** (+163 additions, -78 deletions) <details> <summary>View changed files</summary> 📝 `server/images.go` (+19 -0) 📝 `server/routes.go` (+21 -13) 📝 `server/routes_test.go` (+116 -65) 📝 `types/model/name.go` (+7 -0) </details> ### 📄 Description This change allows for mixed-case model names to be pushed, pulled, copied, and created, which was previously disallowed because the Ollama registry was backed by a Docker registry that enforced a naming convention that disallowed mixed-case names, which is no longer the case. This does not break existing, intended, behaviors. Also, make TestCase test a story of creating, updating, pulling, and copying a model with case variations, ensuring the model's manifest is updated correctly, and not duplicated across different files with different case variations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 06:13:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#17756
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?