github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #4292] [CLOSED] remove last bits of ParseModelPath #16711

New Issue
Closed
opened 2026-04-16 05:40:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 05:40:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/4292
Author: @mxyng
Created: 5/9/2024
Status: ❌ Closed

Base: mxyng/modelname-7 ← Head: mxyng/modelname-8

📝 Commits (10+)

  • eeba2cb update delete handler to use model.Name
  • 14f9dc4 routes: use Manifests for ListHandler
  • 6f2a09a remove DeleteModel
  • 34a1dbe filepath.Join
  • 8215545 more resilient Manifests
  • b91cf08 update create handler to use model.Name
  • 0aeaeaa update pull handler to use model.Name
  • 7cb2fd3 fix(server): prune files
  • af11838 update push to use model.Name
  • 980070d remove last bits of ParseModelPath

📊 Changes

15 files changed (+595 additions, -851 deletions)

View changed files

📝 app/lifecycle/server_windows.go (+4 -2)
📝 readline/readline.go (+1 -1)
📝 server/download.go (+7 -6)
📝 server/images.go (+50 -338)
📝 server/layer.go (+81 -0)
📝 server/manifest.go (+152 -21)
➕ server/manifest_test.go (+94 -0)
📝 server/model.go (+5 -7)
📝 server/modelpath.go (+0 -120)
📝 server/modelpath_test.go (+0 -85)
📝 server/routes.go (+151 -233)
📝 server/routes_test.go (+7 -5)
📝 server/sched.go (+1 -1)
📝 server/sched_test.go (+15 -14)
📝 server/upload.go (+27 -18)

📄 Description

follow up to #4291

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/4292 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 5/9/2024 **Status:** ❌ Closed **Base:** `mxyng/modelname-7` ← **Head:** `mxyng/modelname-8` --- ### 📝 Commits (10+) - [`eeba2cb`](https://github.com/ollama/ollama/commit/eeba2cbae3017b10bcec9c445b9ed1d2bd9c713c) update delete handler to use model.Name - [`14f9dc4`](https://github.com/ollama/ollama/commit/14f9dc4e6a480acf8fc757b7cd6fc0110facb3fb) routes: use Manifests for ListHandler - [`6f2a09a`](https://github.com/ollama/ollama/commit/6f2a09abfd5808372347535dbffa17564ac0c376) remove DeleteModel - [`34a1dbe`](https://github.com/ollama/ollama/commit/34a1dbe6ec687bd69c3866db1e9d5806bd2e4a8c) filepath.Join - [`8215545`](https://github.com/ollama/ollama/commit/8215545c6deea891a98bc26c426291f6932a7576) more resilient Manifests - [`b91cf08`](https://github.com/ollama/ollama/commit/b91cf0893db3dca5685f6fa55b51a5b67d1274fd) update create handler to use model.Name - [`0aeaeaa`](https://github.com/ollama/ollama/commit/0aeaeaa058fdd3f893b3f1211dad1938d0edaf49) update pull handler to use model.Name - [`7cb2fd3`](https://github.com/ollama/ollama/commit/7cb2fd35553b25e9341537ee00a4f6eab339b32e) fix(server): prune files - [`af11838`](https://github.com/ollama/ollama/commit/af11838245c125de9208e53b23e2e5fddcfeb045) update push to use model.Name - [`980070d`](https://github.com/ollama/ollama/commit/980070dce6e6d98aa883f8d519e76ce602066897) remove last bits of ParseModelPath ### 📊 Changes **15 files changed** (+595 additions, -851 deletions) <details> <summary>View changed files</summary> 📝 `app/lifecycle/server_windows.go` (+4 -2) 📝 `readline/readline.go` (+1 -1) 📝 `server/download.go` (+7 -6) 📝 `server/images.go` (+50 -338) 📝 `server/layer.go` (+81 -0) 📝 `server/manifest.go` (+152 -21) ➕ `server/manifest_test.go` (+94 -0) 📝 `server/model.go` (+5 -7) 📝 `server/modelpath.go` (+0 -120) 📝 `server/modelpath_test.go` (+0 -85) 📝 `server/routes.go` (+151 -233) 📝 `server/routes_test.go` (+7 -5) 📝 `server/sched.go` (+1 -1) 📝 `server/sched_test.go` (+15 -14) 📝 `server/upload.go` (+27 -18) </details> ### 📄 Description follow up to #4291 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 05:40:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#16711
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?