[PR #1619] [MERGED] fix(test): use real version string for comparison #15900

Closed
opened 2026-04-16 05:11:26 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/1619
Author: @mxyng
Created: 12/19/2023
Status: Merged
Merged: 12/19/2023
Merged by: @mxyng

Base: mainHead: mxyng/fix-version-test


📝 Commits (1)

  • 63aac0e fix(test): use real version string for comparison

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 server/routes_test.go (+2 -1)

📄 Description

nix passes in the any configured build flags to test which means it's being run with, among other things, ldflags, e.g.:

go test -v -ldflags='-X github.com/jmorganca/ollama/version.Version=x.y.z' ./...

resolves #1613


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/1619 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 12/19/2023 **Status:** ✅ Merged **Merged:** 12/19/2023 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/fix-version-test` --- ### 📝 Commits (1) - [`63aac0e`](https://github.com/ollama/ollama/commit/63aac0edc59dd368050cb12a213af482dec71875) fix(test): use real version string for comparison ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/routes_test.go` (+2 -1) </details> ### 📄 Description nix passes in the any configured build flags to test which means it's being run with, among other things, `ldflags`, e.g.: ``` go test -v -ldflags='-X github.com/jmorganca/ollama/version.Version=x.y.z' ./... ``` resolves #1613 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 05:11:26 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#15900