[PR #950] [MERGED] readline windows terminal support #15670

Closed
opened 2026-04-16 05:04:30 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/950
Author: @BruceMacD
Created: 10/30/2023
Status: Merged
Merged: 10/30/2023
Merged by: @BruceMacD

Base: mainHead: brucemacd/windows-term


📝 Commits (2)

  • ed66e80 readline windows terminal support
  • fe75711 Update term_windows.go

📊 Changes

3 files changed (+68 additions, -3 deletions)

View changed files

📝 readline/buffer.go (+3 -1)
📝 readline/readline.go (+3 -2)
readline/term_windows.go (+62 -0)

📄 Description

  • update the readline package to have basic support on windows, this is not full feature parity with the unix cli yet

This change adds a readline implementation that works on Windows. I dont expect this will work for all features (keyboard short-cuts probably need work). This change also fixes go build . on windows.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/950 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 10/30/2023 **Status:** ✅ Merged **Merged:** 10/30/2023 **Merged by:** [@BruceMacD](https://github.com/BruceMacD) **Base:** `main` ← **Head:** `brucemacd/windows-term` --- ### 📝 Commits (2) - [`ed66e80`](https://github.com/ollama/ollama/commit/ed66e80d6cde2e0424bcb58c2d0f750d8af1c73d) readline windows terminal support - [`fe75711`](https://github.com/ollama/ollama/commit/fe757114bcf0316e14df57e15ee9ea9243422799) Update term_windows.go ### 📊 Changes **3 files changed** (+68 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `readline/buffer.go` (+3 -1) 📝 `readline/readline.go` (+3 -2) ➕ `readline/term_windows.go` (+62 -0) </details> ### 📄 Description - update the readline package to have basic support on windows, this is not full feature parity with the unix cli yet This change adds a readline implementation that works on Windows. I dont expect this will work for all features (keyboard short-cuts probably need work). This change also fixes `go build .` on windows. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 05:04:30 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#15670