[PR #469] [MERGED] metal: add missing barriers for mul-mat #15438

Closed
opened 2026-04-16 04:59:22 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/469
Author: @BruceMacD
Created: 9/5/2023
Status: Merged
Merged: 9/5/2023
Merged by: @BruceMacD

Base: mainHead: brucemacd/metal-sync


📝 Commits (4)

  • 6318340 fix synchronization in new matrix multiplication kernel
  • 87ae0b3 metal: add missing barriers for mul-mat
  • ef6f2a6 backport as separate patches
  • ba0b4cb Merge pull request #470 from jmorganca/mxyng/metal-sync

📊 Changes

6 files changed (+111 additions, -2 deletions)

View changed files

📝 llm/llama.cpp/generate.go (+3 -1)
📝 llm/llama.cpp/generate_darwin_amd64.go (+2 -0)
📝 llm/llama.cpp/generate_darwin_arm64.go (+3 -1)
llm/llama.cpp/ggml_patch/0003-metal-add-missing-barriers-for-mul-mat-2699.patch (+32 -0)
llm/llama.cpp/ggml_patch/0003-metal-fix-synchronization-in-new-matrix-multiplicati.patch (+30 -0)
llm/llama.cpp/ggml_patch/0004-metal-add-missing-barriers-for-mul-mat-2699.patch (+41 -0)

📄 Description

port
https://github.com/ggerganov/llama.cpp/pull/2699
to fix null response on generate


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/469 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 9/5/2023 **Status:** ✅ Merged **Merged:** 9/5/2023 **Merged by:** [@BruceMacD](https://github.com/BruceMacD) **Base:** `main` ← **Head:** `brucemacd/metal-sync` --- ### 📝 Commits (4) - [`6318340`](https://github.com/ollama/ollama/commit/63183408ab9a0232e1eafdae9a4f20d3e1541c6a) fix synchronization in new matrix multiplication kernel - [`87ae0b3`](https://github.com/ollama/ollama/commit/87ae0b367f970657cea8842eb87aca968cd81d23) metal: add missing barriers for mul-mat - [`ef6f2a6`](https://github.com/ollama/ollama/commit/ef6f2a6fa25d21e02cfb2e20de0ffe93946f2c9f) backport as separate patches - [`ba0b4cb`](https://github.com/ollama/ollama/commit/ba0b4cbd9da0363c715cbff9d923ca5a9dbbd6ba) Merge pull request #470 from jmorganca/mxyng/metal-sync ### 📊 Changes **6 files changed** (+111 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `llm/llama.cpp/generate.go` (+3 -1) 📝 `llm/llama.cpp/generate_darwin_amd64.go` (+2 -0) 📝 `llm/llama.cpp/generate_darwin_arm64.go` (+3 -1) ➕ `llm/llama.cpp/ggml_patch/0003-metal-add-missing-barriers-for-mul-mat-2699.patch` (+32 -0) ➕ `llm/llama.cpp/ggml_patch/0003-metal-fix-synchronization-in-new-matrix-multiplicati.patch` (+30 -0) ➕ `llm/llama.cpp/ggml_patch/0004-metal-add-missing-barriers-for-mul-mat-2699.patch` (+41 -0) </details> ### 📄 Description port https://github.com/ggerganov/llama.cpp/pull/2699 to fix null response on generate --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 04:59:22 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#15438