github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #457] [MERGED] do not HTML-escape prompt #15431

New Issue
Closed
opened 2026-04-16 04:59:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 04:59:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/457
Author: @sqs
Created: 9/1/2023
Status: ✅ Merged
Merged: 9/2/2023
Merged by: @mxyng

Base: main ← Head: dont-html-escape-prompt

📝 Commits (1)

  • 62d29b2 do not HTML-escape prompt

📊 Changes

2 files changed (+24 additions, -1 deletions)

View changed files

📝 server/images.go (+1 -1)
➕ server/images_test.go (+23 -0)

📄 Description

The html/template package automatically HTML-escapes interpolated strings in templates. This behavior is undesirable because it causes prompts like <h1>hello to be escaped to &lt;h1&gt;hello before being passed to the LLM.

The included test case passes, but before the code change, it failed:

--- FAIL: TestModelPrompt
    images_test.go:21: got "a&lt;h1&gt;b", want "a<h1>b"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/457 **Author:** [@sqs](https://github.com/sqs) **Created:** 9/1/2023 **Status:** ✅ Merged **Merged:** 9/2/2023 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `dont-html-escape-prompt` --- ### 📝 Commits (1) - [`62d29b2`](https://github.com/ollama/ollama/commit/62d29b2157d8fec5ec45de7a9fa70fc6fcf02408) do not HTML-escape prompt ### 📊 Changes **2 files changed** (+24 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/images.go` (+1 -1) ➕ `server/images_test.go` (+23 -0) </details> ### 📄 Description The `html/template` package automatically HTML-escapes interpolated strings in templates. This behavior is undesirable because it causes prompts like `<h1>hello` to be escaped to `&lt;h1&gt;hello` before being passed to the LLM. The included test case passes, but before the code change, it failed: ``` --- FAIL: TestModelPrompt images_test.go:21: got "a&lt;h1&gt;b", want "a<h1>b" ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 04:59:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#15431
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?