github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #443] [MERGED] windows: fix filepath bugs #15423

New Issue
Closed
opened 2026-04-16 04:58:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 04:58:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/443
Author: @mxyng
Created: 8/30/2023
Status: ✅ Merged
Merged: 8/31/2023
Merged by: @mxyng

Base: main ← Head: mxyng/fix-list-models

📝 Commits (4)

  • 0f541a0 s/ListResponseModel/ModelResponse/
  • eeb40a6 fix list models for windows
  • ae950b0 windows: fix delete
  • 1c8fd62 windows: fix create modelfile

📊 Changes

4 files changed (+49 additions, -73 deletions)

View changed files

📝 api/types.go (+2 -2)
📝 server/images.go (+32 -43)
📝 server/modelpath.go (+1 -1)
📝 server/routes.go (+14 -27)

📄 Description

List and Delete has the same issue where the path was constructed using Linux/macOS path separators which does not work in Windows. This PR fixes and simplifies the code.

Fix filenameWithPath which also assumes a Linux/macOS path separator when looking for ~.

Use filenameWithPath to resolve adapter filepath

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/443 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 8/30/2023 **Status:** ✅ Merged **Merged:** 8/31/2023 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/fix-list-models` --- ### 📝 Commits (4) - [`0f541a0`](https://github.com/ollama/ollama/commit/0f541a03677863026ffa17367359a7f0bbfb6afe) s/ListResponseModel/ModelResponse/ - [`eeb40a6`](https://github.com/ollama/ollama/commit/eeb40a672c80f0cc06b08faaebec67b954202e4f) fix list models for windows - [`ae950b0`](https://github.com/ollama/ollama/commit/ae950b00f19ccef2c02523cc9519de535500d9b3) windows: fix delete - [`1c8fd62`](https://github.com/ollama/ollama/commit/1c8fd627ad9e96f58bad346d5f5a13750700f76a) windows: fix create modelfile ### 📊 Changes **4 files changed** (+49 additions, -73 deletions) <details> <summary>View changed files</summary> 📝 `api/types.go` (+2 -2) 📝 `server/images.go` (+32 -43) 📝 `server/modelpath.go` (+1 -1) 📝 `server/routes.go` (+14 -27) </details> ### 📄 Description List and Delete has the same issue where the path was constructed using Linux/macOS path separators which does not work in Windows. This PR fixes and simplifies the code. Fix `filenameWithPath` which also assumes a Linux/macOS path separator when looking for `~`. Use `filenameWithPath` to resolve adapter filepath --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 04:58:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#15423
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?