[PR #428] [MERGED] update upload chunks #15418

Closed
opened 2026-04-16 04:58:42 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/428
Author: @mxyng
Created: 8/27/2023
Status: Merged
Merged: 8/30/2023
Merged by: @mxyng

Base: mainHead: mxyng/upload-chunks


📝 Commits (4)

📊 Changes

5 files changed (+91 additions, -51 deletions)

View changed files

📝 api/client.go (+2 -2)
📝 server/auth.go (+1 -1)
📝 server/download.go (+1 -1)
📝 server/images.go (+9 -9)
📝 server/upload.go (+78 -38)

📄 Description

This PR increases the upload chunk size which will improve throughput. In order to prove more responsive progress bar, this PR changes the file reader back to a pipe. It keeps the main reader as a SectionReader for simplicity.

Minor change to HTTP status code checks: errors states has been loosened to < 400 (http.StatusBadRequest) for success and >= 400 for failures.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/428 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 8/27/2023 **Status:** ✅ Merged **Merged:** 8/30/2023 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/upload-chunks` --- ### 📝 Commits (4) - [`72266c7`](https://github.com/ollama/ollama/commit/72266c7684842b9720a4facf186a012312f506d9) bump chunk size to 95MB - [`865fceb`](https://github.com/ollama/ollama/commit/865fceb73c7a8284d7bad3cace39fca977a25f3e) chunked pipe - [`246dc65`](https://github.com/ollama/ollama/commit/246dc654173d011dc5506b97715e61fe0fd17634) loosen http status code checks - [`16b0669`](https://github.com/ollama/ollama/commit/16b06699fd83b182a19ccf13078583120a55d714) remove unused parameter ### 📊 Changes **5 files changed** (+91 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `api/client.go` (+2 -2) 📝 `server/auth.go` (+1 -1) 📝 `server/download.go` (+1 -1) 📝 `server/images.go` (+9 -9) 📝 `server/upload.go` (+78 -38) </details> ### 📄 Description This PR increases the upload chunk size which will improve throughput. In order to prove more responsive progress bar, this PR changes the file reader back to a pipe. It keeps the main reader as a SectionReader for simplicity. Minor change to HTTP status code checks: errors states has been loosened to < 400 (http.StatusBadRequest) for success and >= 400 for failures. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 04:58:42 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#15418