github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[GH-ISSUE #2583] How to make a PR to fix a modelfile? #1519

New Issue
Closed
opened 2026-04-12 11:25:40 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-04-12 11:25:40 -05:00
Owner
Copy Link

Originally created by @WolframRavenwolf on GitHub (Feb 18, 2024).
Original GitHub issue: https://github.com/ollama/ollama/issues/2583

Couldn't find the modelfiles in this repo, but would like to fix and make a PR for the Mixtral modelfile. Its prompt format is wrong, fixed it locally, but how to contribute that back to the project?

Originally created by @WolframRavenwolf on GitHub (Feb 18, 2024). Original GitHub issue: https://github.com/ollama/ollama/issues/2583 Couldn't find the modelfiles in this repo, but would like to fix and make a PR for the Mixtral modelfile. Its prompt format is wrong, fixed it locally, but how to contribute that back to the project?
GiteaMirror added the bug label 2026-04-12 11:25:40 -05:00
GiteaMirror commented 2026-04-12 11:25:40 -05:00
Author
Owner
Copy Link

@commit4ever commented on GitHub (Feb 19, 2024):

Could you elaborate on what is wrong so others maybe could patch till the PR is done?

<!-- gh-comment-id:1951673902 --> @commit4ever commented on GitHub (Feb 19, 2024): Could you elaborate on what is wrong so others maybe could patch till the PR is done?
GiteaMirror commented 2026-04-12 11:25:41 -05:00
Author
Owner
Copy Link

@WolframRavenwolf commented on GitHub (Feb 19, 2024):

There's a leading space in the prompt where there should be none. Mistral uses the same format and is correct.

So that's an easy fix, just remove the leading space. However, I'd also like to know what's the proper process to fix modelfiles, in case there are other such cases.

<!-- gh-comment-id:1952245981 --> @WolframRavenwolf commented on GitHub (Feb 19, 2024): There's a leading space in the prompt where there should be none. Mistral uses the same format and is correct. So that's an easy fix, just remove the leading space. However, I'd also like to know what's the proper process to fix modelfiles, in case there are other such cases.
GiteaMirror commented 2026-04-12 11:25:41 -05:00
Author
Owner
Copy Link

@pdevine commented on GitHub (May 16, 2024):

Hey @StefanDanielSchwarz . I'm sorry this issue got buried in the avalanche of issues! Thanks so much for taking the time to file it. I've updated each of the 8x7b models to have the correct template (i.e. without the space at the beginning).

Unfortunately there's no way yet for people to contribute to the library Modelfiles, but we're getting closer to opening that up. It will most likely be in a different repo than the main ollama/ollama one. Still trying to work out the details.

<!-- gh-comment-id:2116331733 --> @pdevine commented on GitHub (May 16, 2024): Hey @StefanDanielSchwarz . I'm sorry this issue got buried in the avalanche of issues! Thanks so much for taking the time to file it. I've updated each of the 8x7b models to have the correct template (i.e. without the space at the beginning). Unfortunately there's no way *yet* for people to contribute to the library Modelfiles, but we're getting closer to opening that up. It will most likely be in a different repo than the main `ollama/ollama` one. Still trying to work out the details.
GiteaMirror commented 2026-04-12 11:25:41 -05:00
Author
Owner
Copy Link

@pdevine commented on GitHub (May 16, 2024):

Oh, also, I should note that if you pull the model again with ollama pull mixtral it will only download the new template and it won't pull the weights again.

<!-- gh-comment-id:2116332981 --> @pdevine commented on GitHub (May 16, 2024): Oh, also, I should note that if you pull the model again with `ollama pull mixtral` it will *only* download the new template and it won't pull the weights again.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#1519
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?