github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15467] [MERGED] model/parsers: fix missing parallel tool call indices #15166

New Issue
Closed
opened 2026-04-13 01:11:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 01:11:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15467
Author: @drifkin
Created: 4/10/2026
Status: ✅ Merged
Merged: 4/10/2026
Merged by: @drifkin

Base: main ← Head: drifkin/parallel-tool-call-indices

📝 Commits (1)

  • b37c137 model/parsers: fix missing parallel tool call indices

📊 Changes

16 files changed (+186 additions, -17 deletions)

View changed files

📝 model/parsers/cogito.go (+9 -2)
📝 model/parsers/cogito_test.go (+4 -2)
📝 model/parsers/deepseek3.go (+7 -0)
📝 model/parsers/deepseek3_test.go (+4 -2)
📝 model/parsers/functiongemma.go (+10 -3)
📝 model/parsers/functiongemma_test.go (+6 -0)
📝 model/parsers/gemma4.go (+7 -0)
📝 model/parsers/gemma4_test.go (+4 -2)
📝 model/parsers/lfm2.go (+7 -0)
📝 model/parsers/lfm2_test.go (+8 -4)
📝 model/parsers/ministral.go (+7 -0)
📝 model/parsers/ministral_test.go (+49 -0)
📝 model/parsers/olmo3.go (+9 -2)
📝 model/parsers/olmo3_test.go (+2 -0)
📝 model/parsers/qwen3vl.go (+7 -0)
📝 model/parsers/qwen3vl_nonthinking_test.go (+46 -0)

📄 Description

We were missing setting the function index for several models that can make parallel tool calls.

In the future we may want to consider putting some sort of post-parse hook and relieve the parsers of this duty.

Fixes: #15457

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15467 **Author:** [@drifkin](https://github.com/drifkin) **Created:** 4/10/2026 **Status:** ✅ Merged **Merged:** 4/10/2026 **Merged by:** [@drifkin](https://github.com/drifkin) **Base:** `main` ← **Head:** `drifkin/parallel-tool-call-indices` --- ### 📝 Commits (1) - [`b37c137`](https://github.com/ollama/ollama/commit/b37c137022b8b0b3847c5186222adc9e300de1e1) model/parsers: fix missing parallel tool call indices ### 📊 Changes **16 files changed** (+186 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `model/parsers/cogito.go` (+9 -2) 📝 `model/parsers/cogito_test.go` (+4 -2) 📝 `model/parsers/deepseek3.go` (+7 -0) 📝 `model/parsers/deepseek3_test.go` (+4 -2) 📝 `model/parsers/functiongemma.go` (+10 -3) 📝 `model/parsers/functiongemma_test.go` (+6 -0) 📝 `model/parsers/gemma4.go` (+7 -0) 📝 `model/parsers/gemma4_test.go` (+4 -2) 📝 `model/parsers/lfm2.go` (+7 -0) 📝 `model/parsers/lfm2_test.go` (+8 -4) 📝 `model/parsers/ministral.go` (+7 -0) 📝 `model/parsers/ministral_test.go` (+49 -0) 📝 `model/parsers/olmo3.go` (+9 -2) 📝 `model/parsers/olmo3_test.go` (+2 -0) 📝 `model/parsers/qwen3vl.go` (+7 -0) 📝 `model/parsers/qwen3vl_nonthinking_test.go` (+46 -0) </details> ### 📄 Description We were missing setting the function index for several models that can make parallel tool calls. In the future we may want to consider putting some sort of post-parse hook and relieve the parsers of this duty. Fixes: #15457 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 01:11:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#15166
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?