[PR #15340] docs: clarify transfer package interruption semantics #15118

Open
opened 2026-04-13 01:10:44 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15340
Author: @addu2612
Created: 4/5/2026
Status: 🔄 Open

Base: mainHead: arnav-transfer-comment-clarity


📝 Commits (1)

  • 9bb1b7b docs: clarify transfer package interruption semantics

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 x/imagegen/transfer/transfer.go (+5 -0)

📄 Description

This clarifies the package-level comment in x/imagegen/transfer/transfer.go to make the interruption semantics more explicit for contributors.

In particular, it now calls out that this transfer path intentionally prefers whole-blob retries for many-small-blob workloads, and that its behavior differs from server/download.go, which supports resumable part-based downloads.

This is a small contributor-facing clarification tied to the current discussion around interrupted pull behavior.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15340 **Author:** [@addu2612](https://github.com/addu2612) **Created:** 4/5/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `arnav-transfer-comment-clarity` --- ### 📝 Commits (1) - [`9bb1b7b`](https://github.com/ollama/ollama/commit/9bb1b7b0a5db01fc23062b2b094704a4d107cd1f) docs: clarify transfer package interruption semantics ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `x/imagegen/transfer/transfer.go` (+5 -0) </details> ### 📄 Description This clarifies the package-level comment in `x/imagegen/transfer/transfer.go` to make the interruption semantics more explicit for contributors. In particular, it now calls out that this transfer path intentionally prefers whole-blob retries for many-small-blob workloads, and that its behavior differs from `server/download.go`, which supports resumable part-based downloads. This is a small contributor-facing clarification tied to the current discussion around interrupted pull behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 01:10:44 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#15118