github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14941] [MERGED] cmd/launch: skip redundant config writes when model unchanged #14931

New Issue
Closed
opened 2026-04-13 01:06:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 01:06:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14941
Author: @hoyyeva
Created: 3/18/2026
Status: ✅ Merged
Merged: 3/18/2026
Merged by: @hoyyeva

Base: main ← Head: hoyyeva/skip-redundant-config-writes

📝 Commits (1)

  • d574d98 cmd/launch: skip redundant config writes when model unchanged

📊 Changes

1 file changed (+8 additions, -10 deletions)

View changed files

📝 cmd/launch/launch.go (+8 -10)

📄 Description

  • launchSingleIntegration unconditionally called SaveIntegration on every launch, even when the model hadn't changed. The editor integration flow already guarded against this. This aligns the single model flow to match.
  • resolveRunModel called SetLastModel(current) in two paths where current was just read from config.LastModel() — a no-op write. Removed those, and guarded the post-selector write with a change check.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14941 **Author:** [@hoyyeva](https://github.com/hoyyeva) **Created:** 3/18/2026 **Status:** ✅ Merged **Merged:** 3/18/2026 **Merged by:** [@hoyyeva](https://github.com/hoyyeva) **Base:** `main` ← **Head:** `hoyyeva/skip-redundant-config-writes` --- ### 📝 Commits (1) - [`d574d98`](https://github.com/ollama/ollama/commit/d574d98086c0a926c795ad94744e10d0d2eecb5f) cmd/launch: skip redundant config writes when model unchanged ### 📊 Changes **1 file changed** (+8 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `cmd/launch/launch.go` (+8 -10) </details> ### 📄 Description - `launchSingleIntegration` unconditionally called `SaveIntegration` on every launch, even when the model hadn't changed. The editor integration flow already guarded against this. This aligns the single model flow to match. - `resolveRunModel` called `SetLastModel(current)` in two paths where current was just read from `config.LastModel()` — a no-op write. Removed those, and guarded the post-selector write with a change check. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 01:06:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14931
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?