github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14838] fix: Handle json.Unmarshal error in checkError function #14868

New Issue
Open
opened 2026-04-13 01:04:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 01:04:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14838
Author: @LincolnBurrows2017
Created: 3/14/2026
Status: 🔄 Open

Base: main ← Head: fix-auth-error-handling

📝 Commits (2)

  • c48be94 fix: correct typo ViewSeperator -> ViewSeparator in deepseekocr model
  • 50b191e fix: use consistent binary units (TiB/GiB/MiB/KiB) in HumanBytes

📊 Changes

3 files changed (+42 additions, -35 deletions)

View changed files

📝 format/bytes.go (+15 -12)
📝 format/bytes_test.go (+25 -20)
📝 model/models/deepseekocr/model.go (+2 -3)

📄 Description

Summary

In api/client.go line 50, the json.Unmarshal error was silently ignored when handling HTTP 401 Unauthorized responses.

Fix

Added proper error handling:

if err := json.Unmarshal(body, &authError); err != nil {
    authError.Status = string(body)
}

This matches the error handling pattern used for StatusError on line 56.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14838 **Author:** [@LincolnBurrows2017](https://github.com/LincolnBurrows2017) **Created:** 3/14/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-auth-error-handling` --- ### 📝 Commits (2) - [`c48be94`](https://github.com/ollama/ollama/commit/c48be94ac71ffe697cb92e7ca4b8eecd6d93826b) fix: correct typo ViewSeperator -> ViewSeparator in deepseekocr model - [`50b191e`](https://github.com/ollama/ollama/commit/50b191edede819049e59fa6ce791054942360ab8) fix: use consistent binary units (TiB/GiB/MiB/KiB) in HumanBytes ### 📊 Changes **3 files changed** (+42 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `format/bytes.go` (+15 -12) 📝 `format/bytes_test.go` (+25 -20) 📝 `model/models/deepseekocr/model.go` (+2 -3) </details> ### 📄 Description ## Summary In `api/client.go` line 50, the `json.Unmarshal` error was silently ignored when handling HTTP 401 Unauthorized responses. ## Fix Added proper error handling: ```go if err := json.Unmarshal(body, &authError); err != nil { authError.Status = string(body) } ``` This matches the error handling pattern used for `StatusError` on line 56. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 01:04:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14868
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?