github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 16:40:08 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14828] [MERGED] middleware: handle non-JSON error responses gracefully #14862

New Issue
Closed
opened 2026-04-13 01:04:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 01:04:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14828
Author: @BruceMacD
Created: 3/13/2026
Status: ✅ Merged
Merged: 3/13/2026
Merged by: @BruceMacD

Base: main ← Head: brucemacd/cloud-proxy-err-parse

📝 Commits (1)

  • ea3e36b middleware: handle non-JSON error responses gracefully

📊 Changes

3 files changed (+10 additions, -9 deletions)

View changed files

📝 middleware/anthropic.go (+4 -3)
📝 middleware/openai.go (+5 -5)
📝 middleware/openai_test.go (+1 -1)

📄 Description

writeError in both OpenAI and Anthropic middleware writers would return a raw json.SyntaxError when the error payload wasn't valid JSON (e.g. "invalid character 'e' looking for beginning of value"). Fall back to using the raw bytes as the error message instead.

Also use the actual HTTP status code rather than hardcoding 500, so error types map correctly

Found from #14827

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14828 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 3/13/2026 **Status:** ✅ Merged **Merged:** 3/13/2026 **Merged by:** [@BruceMacD](https://github.com/BruceMacD) **Base:** `main` ← **Head:** `brucemacd/cloud-proxy-err-parse` --- ### 📝 Commits (1) - [`ea3e36b`](https://github.com/ollama/ollama/commit/ea3e36be7c125a03a03156f7c5c5aaaa6cd25ab0) middleware: handle non-JSON error responses gracefully ### 📊 Changes **3 files changed** (+10 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `middleware/anthropic.go` (+4 -3) 📝 `middleware/openai.go` (+5 -5) 📝 `middleware/openai_test.go` (+1 -1) </details> ### 📄 Description writeError in both OpenAI and Anthropic middleware writers would return a raw json.SyntaxError when the error payload wasn't valid JSON (e.g. "invalid character 'e' looking for beginning of value"). Fall back to using the raw bytes as the error message instead. Also use the actual HTTP status code rather than hardcoding 500, so error types map correctly Found from #14827 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 01:04:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14862
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?