github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14714] llm: use %w instead of %v for proper error wrapping #14806

New Issue
Open
opened 2026-04-13 01:02:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 01:02:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14714
Author: @gambletan
Created: 3/8/2026
Status: 🔄 Open

Base: main ← Head: fix/llm-server-error-wrapping

📝 Commits (1)

  • 6ba66cc llm: use %w instead of %v for error wrapping in server.go

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 llm/server.go (+6 -6)

📄 Description

What

Replace %v with %w in fmt.Errorf calls throughout llm/server.go.

Why

Using %v to format errors in fmt.Errorf discards the error chain, making it impossible for callers to use errors.Is() or errors.As() to inspect the underlying cause. This matters for error handling in several cases:

  • Runner startup errors (line 291): callers can't check if the underlying error is a specific type like exec.Error or context.DeadlineExceeded
  • HTTP request creation errors (lines 1277, 1601): callers can't detect url.Error or similar
  • JSON marshaling/unmarshaling errors (lines 1595, 1650): callers can't distinguish between different JSON error types
  • Response reading errors (line 1692): callers can't check for io.EOF or network errors

The %w verb was introduced in Go 1.13 specifically to preserve the error chain in wrapped errors.

Change

Six %v → %w replacements in fmt.Errorf calls in llm/server.go.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14714 **Author:** [@gambletan](https://github.com/gambletan) **Created:** 3/8/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/llm-server-error-wrapping` --- ### 📝 Commits (1) - [`6ba66cc`](https://github.com/ollama/ollama/commit/6ba66ccd4a4e543f7396cb7ab7eb0babcc139851) llm: use %w instead of %v for error wrapping in server.go ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `llm/server.go` (+6 -6) </details> ### 📄 Description ## What Replace `%v` with `%w` in `fmt.Errorf` calls throughout `llm/server.go`. ## Why Using `%v` to format errors in `fmt.Errorf` discards the error chain, making it impossible for callers to use `errors.Is()` or `errors.As()` to inspect the underlying cause. This matters for error handling in several cases: - **Runner startup errors** (line 291): callers can't check if the underlying error is a specific type like `exec.Error` or `context.DeadlineExceeded` - **HTTP request creation errors** (lines 1277, 1601): callers can't detect `url.Error` or similar - **JSON marshaling/unmarshaling errors** (lines 1595, 1650): callers can't distinguish between different JSON error types - **Response reading errors** (line 1692): callers can't check for `io.EOF` or network errors The `%w` verb was introduced in Go 1.13 specifically to preserve the error chain in wrapped errors. ## Change Six `%v` → `%w` replacements in `fmt.Errorf` calls in `llm/server.go`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 01:02:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14806
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?