github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 16:40:08 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14713] readline: check errors from Flush and Close in history Save #14805

New Issue
Open
opened 2026-04-13 01:02:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 01:02:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14713
Author: @alvinttang
Created: 3/8/2026
Status: 🔄 Open

Base: main ← Head: fix/history-save-flush-error

📝 Commits (1)

  • 3b61a98 readline: check errors from Flush and Close in history Save

📊 Changes

1 file changed (+11 additions, -3 deletions)

View changed files

📝 readline/history.go (+11 -3)

📄 Description

What

Check errors from bufio.Writer.Flush(), fmt.Fprintln(), and os.File.Close() in History.Save().

Why

Currently Save() ignores errors from buf.Flush() (line 143) and f.Close() (line 144). If writing fails (disk full, I/O error), the buffered data is silently lost and the incomplete/empty temp file is renamed over the existing history file, corrupting or destroying the user's command history.

The f.Close() error is also important because on some filesystems (e.g., NFS), Close() can return write errors that were deferred from earlier Write() calls.

Change

  • Check the error from fmt.Fprintln() during each line write
  • Check the error from buf.Flush() before closing the file
  • Check the error from f.Close() before renaming
  • On any error, return early without renaming the temp file over the history

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14713 **Author:** [@alvinttang](https://github.com/alvinttang) **Created:** 3/8/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/history-save-flush-error` --- ### 📝 Commits (1) - [`3b61a98`](https://github.com/ollama/ollama/commit/3b61a98d7fc586aaa5afaeca1df9f07a9264f5d4) readline: check errors from Flush and Close in history Save ### 📊 Changes **1 file changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `readline/history.go` (+11 -3) </details> ### 📄 Description ## What Check errors from `bufio.Writer.Flush()`, `fmt.Fprintln()`, and `os.File.Close()` in `History.Save()`. ## Why Currently `Save()` ignores errors from `buf.Flush()` (line 143) and `f.Close()` (line 144). If writing fails (disk full, I/O error), the buffered data is silently lost and the incomplete/empty temp file is renamed over the existing history file, corrupting or destroying the user's command history. The `f.Close()` error is also important because on some filesystems (e.g., NFS), `Close()` can return write errors that were deferred from earlier `Write()` calls. ## Change - Check the error from `fmt.Fprintln()` during each line write - Check the error from `buf.Flush()` before closing the file - Check the error from `f.Close()` before renaming - On any error, return early without renaming the temp file over the history --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 01:02:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14805
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?