[PR #14679] [MERGED] create: Clean up experimental paths, fix create from existing safetensor model #14783

Closed
opened 2026-04-13 01:02:33 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14679
Author: @dhiltgen
Created: 3/6/2026
Status: Merged
Merged: 4/7/2026
Merged by: @dhiltgen

Base: mainHead: create


📝 Commits (3)

  • 8fe8889 create: Clean up experimental paths
  • 43eb7f1 create: preserve config and layer names when creating from safetensors models
  • 0ecc8b1 review comments

📊 Changes

15 files changed (+1292 additions, -22 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 cmd/cmd.go (+3 -13)
integration/create_imagegen_test.go (+107 -0)
integration/create_test.go (+350 -0)
📝 server/create.go (+4 -1)
📝 server/model.go (+3 -2)
📝 server/routes_create_test.go (+269 -0)
📝 x/create/client/create.go (+1 -1)
📝 x/create/client/create_test.go (+156 -0)
📝 x/create/create.go (+1 -1)
📝 x/create/create_test.go (+1 -1)
📝 x/create/imagegen.go (+1 -1)
📝 x/create/qwen35.go (+1 -1)
📝 x/safetensors/extractor.go (+0 -1)
x/safetensors/extractor_test.go (+394 -0)

📄 Description

This cleans up the experimental features, and adds both unit and integration test coverage to verify no regressions.

Also fixes create from existing safetensor model


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14679 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 3/6/2026 **Status:** ✅ Merged **Merged:** 4/7/2026 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `create` --- ### 📝 Commits (3) - [`8fe8889`](https://github.com/ollama/ollama/commit/8fe8889f5ec31907ac9d2a0b04124d27bbdc38b7) create: Clean up experimental paths - [`43eb7f1`](https://github.com/ollama/ollama/commit/43eb7f1d5ec6a21ff51f8a40e55578ce6b003317) create: preserve config and layer names when creating from safetensors models - [`0ecc8b1`](https://github.com/ollama/ollama/commit/0ecc8b1f3b97c0dbe45ec642139f2281581f387a) review comments ### 📊 Changes **15 files changed** (+1292 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `cmd/cmd.go` (+3 -13) ➕ `integration/create_imagegen_test.go` (+107 -0) ➕ `integration/create_test.go` (+350 -0) 📝 `server/create.go` (+4 -1) 📝 `server/model.go` (+3 -2) 📝 `server/routes_create_test.go` (+269 -0) 📝 `x/create/client/create.go` (+1 -1) 📝 `x/create/client/create_test.go` (+156 -0) 📝 `x/create/create.go` (+1 -1) 📝 `x/create/create_test.go` (+1 -1) 📝 `x/create/imagegen.go` (+1 -1) 📝 `x/create/qwen35.go` (+1 -1) 📝 `x/safetensors/extractor.go` (+0 -1) ➕ `x/safetensors/extractor_test.go` (+394 -0) </details> ### 📄 Description This cleans up the experimental features, and adds both unit and integration test coverage to verify no regressions. Also fixes create from existing safetensor model --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 01:02:33 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14783