github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-08 08:59:13 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14656] [MERGED] parsers: repair unclosed arg_value tags in GLM tool calls #14770

New Issue
Closed
opened 2026-04-13 01:02:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 01:02:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14656
Author: @BruceMacD
Created: 3/6/2026
Status: ✅ Merged
Merged: 3/6/2026
Merged by: @BruceMacD

Base: main ← Head: brucemacd/glm-tag-recover

📝 Commits (1)

  • 77f0736 parsers: repair unclosed arg_value tags in GLM tool calls

📊 Changes

3 files changed (+175 additions, -4 deletions)

View changed files

📝 model/parsers/glm46.go (+47 -2)
📝 model/parsers/glm46_test.go (+83 -0)
📝 x/models/glm4_moe_lite/parser.go (+45 -2)

📄 Description

GLM models sometimes omits </arg_value> closing tags in tool call XML, causing xml.Unmarshal to fail with "element <arg_value> closed by </tool_call>".

This is a known issue across the GLM family.

Sanitize the input to fix closing arg_key values so encoding/xml can handle it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14656 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 3/6/2026 **Status:** ✅ Merged **Merged:** 3/6/2026 **Merged by:** [@BruceMacD](https://github.com/BruceMacD) **Base:** `main` ← **Head:** `brucemacd/glm-tag-recover` --- ### 📝 Commits (1) - [`77f0736`](https://github.com/ollama/ollama/commit/77f0736d7e61ddde1ecab7eb73bdb2d7598f51d9) parsers: repair unclosed arg_value tags in GLM tool calls ### 📊 Changes **3 files changed** (+175 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `model/parsers/glm46.go` (+47 -2) 📝 `model/parsers/glm46_test.go` (+83 -0) 📝 `x/models/glm4_moe_lite/parser.go` (+45 -2) </details> ### 📄 Description GLM models sometimes omits </arg_value> closing tags in tool call XML, causing xml.Unmarshal to fail with "element <arg_value> closed by </tool_call>". This is a known issue across the GLM family. Sanitize the input to fix closing arg_key values so encoding/xml can handle it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 01:02:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14770
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?