github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14427] [MERGED] app: fix first update check delayed by 1 hour #14671

New Issue
Closed
opened 2026-04-13 01:00:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 01:00:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14427
Author: @hoyyeva
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @hoyyeva

Base: main ← Head: hoyyeva/initial-check-update

📝 Commits (1)

  • ca27233 app: fix first update check delayed by 1 hour

📊 Changes

3 files changed (+11 additions, -6 deletions)

View changed files

📝 app/cmd/app/app.go (+3 -2)
📝 app/updater/updater.go (+2 -1)
📝 app/updater/updater_test.go (+6 -3)

📄 Description

Summary

  • Fix a regression from #13512 where the first update check was delayed by ~60 minutes instead of ~3 seconds after startup. The refactor changed the loop from check-then-wait to wait-then-check, so the first iteration blocked on the ticker instead of checking immediately.
  • Reuse the existing store.Store in startHiddenTasks() instead of creating a second instance, avoiding an unnecessary duplicate DB connection.
  • Fix a misleading comment that said "regardless of toggle state" on a code path only reachable when auto-update is enabled.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14427 **Author:** [@hoyyeva](https://github.com/hoyyeva) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@hoyyeva](https://github.com/hoyyeva) **Base:** `main` ← **Head:** `hoyyeva/initial-check-update` --- ### 📝 Commits (1) - [`ca27233`](https://github.com/ollama/ollama/commit/ca272334c54503d46ccd740152bd3bfea87fb63f) app: fix first update check delayed by 1 hour ### 📊 Changes **3 files changed** (+11 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `app/cmd/app/app.go` (+3 -2) 📝 `app/updater/updater.go` (+2 -1) 📝 `app/updater/updater_test.go` (+6 -3) </details> ### 📄 Description **Summary** - Fix a regression from #13512 where the first update check was delayed by ~60 minutes instead of ~3 seconds after startup. The refactor changed the loop from check-then-wait to wait-then-check, so the first iteration blocked on the ticker instead of checking immediately. - Reuse the existing store.Store in startHiddenTasks() instead of creating a second instance, avoiding an unnecessary duplicate DB connection. - Fix a misleading comment that said "regardless of toggle state" on a code path only reachable when auto-update is enabled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 01:00:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14671
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?