github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14405] chat: improve chat deletion confirmation dialog #14660

New Issue
Open
opened 2026-04-13 01:00:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 01:00:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14405
Author: @Miguel0888
Created: 2/25/2026
Status: 🔄 Open

Base: main ← Head: main

📝 Commits (1)

  • 906ebfb chat: improve chat deletion confirmation dialog

📊 Changes

1 file changed (+5 additions, -4 deletions)

View changed files

📝 app/ui/app/src/components/ChatSidebar.tsx (+5 -4)

📄 Description

This pull request updates the chat deletion confirmation flow in the ChatSidebar component to use a custom menu instead of the browser's default confirmation dialog. This change provides a more consistent and integrated user experience.

User experience improvements:

  • Replaced the window.confirm dialog with a custom window.menu for chat deletion confirmation in the ChatSidebar component, making the interaction more consistent with the app's UI.

Otherwise the windows app shows a annoying white system dialog!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14405 **Author:** [@Miguel0888](https://github.com/Miguel0888) **Created:** 2/25/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`906ebfb`](https://github.com/ollama/ollama/commit/906ebfb7a0ebf7f04a2b0283d573aaad3da1994d) chat: improve chat deletion confirmation dialog ### 📊 Changes **1 file changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/ui/app/src/components/ChatSidebar.tsx` (+5 -4) </details> ### 📄 Description This pull request updates the chat deletion confirmation flow in the `ChatSidebar` component to use a custom menu instead of the browser's default confirmation dialog. This change provides a more consistent and integrated user experience. User experience improvements: * Replaced the `window.confirm` dialog with a custom `window.menu` for chat deletion confirmation in the `ChatSidebar` component, making the interaction more consistent with the app's UI. Otherwise the windows app shows a annoying white system dialog! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 01:00:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14660
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?