[PR #14379] [MERGED] mlxrunner: Fix duplicate log prefixes and reduce log noise #14645

Closed
opened 2026-04-13 00:59:52 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14379
Author: @jessegross
Created: 2/23/2026
Status: Merged
Merged: 2/23/2026
Merged by: @jessegross

Base: mainHead: jessegross/mlx-logging


📝 Commits (1)

  • 5fe749d mlxrunner: Fix duplicate log prefixes and reduce log noise

📊 Changes

2 files changed (+5 additions, -9 deletions)

View changed files

📝 x/mlxrunner/cache/cache.go (+3 -4)
📝 x/mlxrunner/client.go (+2 -5)

📄 Description

Pass subprocess stdout/stderr through to the parent's stderr directly instead of re-wrapping each line with slog. The subprocess already writes structured slog output, so the re-wrapping produced nested timestamps, levels, and message fields that were hard to read.

Also downgrade verbose KV cache debug logs to trace level.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14379 **Author:** [@jessegross](https://github.com/jessegross) **Created:** 2/23/2026 **Status:** ✅ Merged **Merged:** 2/23/2026 **Merged by:** [@jessegross](https://github.com/jessegross) **Base:** `main` ← **Head:** `jessegross/mlx-logging` --- ### 📝 Commits (1) - [`5fe749d`](https://github.com/ollama/ollama/commit/5fe749d4af24c9d511efa8d73ce9572f7fd294d9) mlxrunner: Fix duplicate log prefixes and reduce log noise ### 📊 Changes **2 files changed** (+5 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `x/mlxrunner/cache/cache.go` (+3 -4) 📝 `x/mlxrunner/client.go` (+2 -5) </details> ### 📄 Description Pass subprocess stdout/stderr through to the parent's stderr directly instead of re-wrapping each line with slog. The subprocess already writes structured slog output, so the re-wrapping produced nested timestamps, levels, and message fields that were hard to read. Also downgrade verbose KV cache debug logs to trace level. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:59:52 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14645