github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #13662] [MERGED] x: request access for all commands, add welcome message #14324

New Issue
Closed
opened 2026-04-13 00:50:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:50:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/13662
Author: @ParthSareen
Created: 1/9/2026
Status: ✅ Merged
Merged: 1/10/2026
Merged by: @ParthSareen

Base: main ← Head: parth-agent-welcome-screen

📝 Commits (3)

  • f33a11f x: add ability to disable bash tool with --no-bash flag and runtime commands
  • be7a27b refactor: rename experimental flags and tighten auto-allowlist
  • 080f948 x: remove --experimental-no-bash flag and /bash commands

📊 Changes

5 files changed (+77 additions, -13 deletions)

View changed files

📝 cmd/cmd.go (+2 -2)
📝 x/agent/approval.go (+3 -3)
📝 x/cmd/run.go (+12 -8)
📝 x/tools/registry.go (+16 -0)
📝 x/tools/registry_test.go (+44 -0)

📄 Description

adds ability to disable bash tool with --no-bash flag and runtime commands

This change allows users to disable the bash tool for safety and control:

  • Add --no-bash flag to disable bash tool at startup
  • Add /bash on and /bash off commands to toggle bash tool at runtime
  • Add welcome message warning users when bash is enabled
  • Refactor Registry to support configuration-based initialization
  • Add Unregister, Has, and RegisterBash methods for runtime tool management
  • Add unit tests for new registry functionality

The bash tool can now be controlled via:

  • CLI flag: ollama run --no-bash
  • Runtime commands: /bash off | /bash on
  • Environment variable: OLLAMA_AGENT_DISABLE_BASH=1

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/13662 **Author:** [@ParthSareen](https://github.com/ParthSareen) **Created:** 1/9/2026 **Status:** ✅ Merged **Merged:** 1/10/2026 **Merged by:** [@ParthSareen](https://github.com/ParthSareen) **Base:** `main` ← **Head:** `parth-agent-welcome-screen` --- ### 📝 Commits (3) - [`f33a11f`](https://github.com/ollama/ollama/commit/f33a11f966b1a97c4cc0d3edba6b069c85a647b6) x: add ability to disable bash tool with --no-bash flag and runtime commands - [`be7a27b`](https://github.com/ollama/ollama/commit/be7a27bb79a22ec1667c5656560c1533db45740f) refactor: rename experimental flags and tighten auto-allowlist - [`080f948`](https://github.com/ollama/ollama/commit/080f94837b480bb263d7021a2f69fe319d36a1b1) x: remove --experimental-no-bash flag and /bash commands ### 📊 Changes **5 files changed** (+77 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `cmd/cmd.go` (+2 -2) 📝 `x/agent/approval.go` (+3 -3) 📝 `x/cmd/run.go` (+12 -8) 📝 `x/tools/registry.go` (+16 -0) 📝 `x/tools/registry_test.go` (+44 -0) </details> ### 📄 Description adds ability to disable bash tool with --no-bash flag and runtime commands This change allows users to disable the bash tool for safety and control: - Add --no-bash flag to disable bash tool at startup - Add /bash on and /bash off commands to toggle bash tool at runtime - Add welcome message warning users when bash is enabled - Refactor Registry to support configuration-based initialization - Add Unregister, Has, and RegisterBash methods for runtime tool management - Add unit tests for new registry functionality The bash tool can now be controlled via: - CLI flag: ollama run --no-bash <model> - Runtime commands: /bash off | /bash on - Environment variable: OLLAMA_AGENT_DISABLE_BASH=1 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:50:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14324
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?