github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #13412] [MERGED] app: fix models folder reset to default and cannot be changed on settings #14195

New Issue
Closed
opened 2026-04-13 00:48:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:48:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/13412
Author: @hoyyeva
Created: 12/10/2025
Status: ✅ Merged
Merged: 12/12/2025
Merged by: @hoyyeva

Base: main ← Head: hoyyeva/models-folder-path-reset

📝 Commits (1)

  • 528f4bd fix: select and update models folder in settings

📊 Changes

2 files changed (+38 additions, -30 deletions)

View changed files

📝 app/dialog/cocoa/dlg.m (+37 -27)
📝 app/server/server.go (+1 -3)

📄 Description

This PR addresses three related issues: #13226, #13364, #12524, and #12883.

The reported problems fall into two categories:

  1. The custom models folder path resets to the default after app restart
  2. The app does not allow selecting a models folder located on an external drive

Bug 1: On startup, server.go aggressively sanitized the configured models path and reset it when the folder was not immediately accessible.
Bug 2: On macOS, the file dialog did not correctly return the selected directory path, preventing users from setting paths on external volumes.

Fixes Included in This PR
Fix 1: Modify the server behaviour so the saved models path is preserved even if it is temporarily inaccessible (e.g., external drive not mounted on startup).

Fix 2: Correct macOS path selection by adding proper handling for single-directory selection in the file dialog.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/13412 **Author:** [@hoyyeva](https://github.com/hoyyeva) **Created:** 12/10/2025 **Status:** ✅ Merged **Merged:** 12/12/2025 **Merged by:** [@hoyyeva](https://github.com/hoyyeva) **Base:** `main` ← **Head:** `hoyyeva/models-folder-path-reset` --- ### 📝 Commits (1) - [`528f4bd`](https://github.com/ollama/ollama/commit/528f4bd5016bf649ffa2c27d05b0b46b169a8973) fix: select and update models folder in settings ### 📊 Changes **2 files changed** (+38 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `app/dialog/cocoa/dlg.m` (+37 -27) 📝 `app/server/server.go` (+1 -3) </details> ### 📄 Description This PR addresses three related issues: #13226, #13364, #12524, and #12883. The reported problems fall into two categories: 1. The custom models folder path resets to the default after app restart 2. The app does not allow selecting a models folder located on an external drive Bug 1: On startup, `server.go` aggressively sanitized the configured models path and reset it when the folder was not immediately accessible. Bug 2: On macOS, the file dialog did not correctly return the selected directory path, preventing users from setting paths on external volumes. Fixes Included in This PR Fix 1: Modify the server behaviour so the saved models path is preserved even if it is temporarily inaccessible (e.g., external drive not mounted on startup). Fix 2: Correct macOS path selection by adding proper handling for single-directory selection in the file dialog. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:48:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14195
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?