[PR #13140] [MERGED] refactor rope #14091

Closed
opened 2026-04-13 00:44:34 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/13140
Author: @mxyng
Created: 11/19/2025
Status: Merged
Merged: 12/8/2025
Merged by: @mxyng

Base: mainHead: mxyng/ropeopts


📝 Commits (1)

📊 Changes

21 files changed (+114 additions, -91 deletions)

View changed files

📝 ml/nn/rope.go (+2 -3)
📝 ml/nn/rope/options.go (+1 -0)
📝 model/models/deepseek2/model.go (+7 -9)
📝 model/models/deepseekocr/model_text.go (+5 -6)
📝 model/models/gemma2/model.go (+7 -4)
📝 model/models/gemma3/model_text.go (+7 -4)
📝 model/models/gemma3n/model_text.go (+7 -4)
📝 model/models/gptoss/model.go (+8 -9)
📝 model/models/llama/model.go (+7 -6)
📝 model/models/llama4/model_text.go (+7 -4)
📝 model/models/mistral3/model_text.go (+7 -4)
📝 model/models/mistral3/model_vision.go (+4 -4)
📝 model/models/mllama/model_text.go (+8 -5)
📝 model/models/nomicbert/model.go (+6 -3)
📝 model/models/qwen2/model.go (+7 -6)
📝 model/models/qwen25vl/model_text.go (+10 -4)
📝 model/models/qwen25vl/model_vision.go (+4 -4)
📝 model/models/qwen3/model.go (+1 -2)
📝 model/models/qwen3vl/model.go (+1 -1)
📝 model/models/qwen3vl/model_text.go (+4 -5)

...and 1 more files

📄 Description

change to a flatter directory structure and group the options with the function

update models to call rope in one place


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/13140 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 11/19/2025 **Status:** ✅ Merged **Merged:** 12/8/2025 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/ropeopts` --- ### 📝 Commits (1) - [`ea70324`](https://github.com/ollama/ollama/commit/ea703247bbdefabaf0d8eb509419ef2666597a3e) refactor rope ### 📊 Changes **21 files changed** (+114 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `ml/nn/rope.go` (+2 -3) 📝 `ml/nn/rope/options.go` (+1 -0) 📝 `model/models/deepseek2/model.go` (+7 -9) 📝 `model/models/deepseekocr/model_text.go` (+5 -6) 📝 `model/models/gemma2/model.go` (+7 -4) 📝 `model/models/gemma3/model_text.go` (+7 -4) 📝 `model/models/gemma3n/model_text.go` (+7 -4) 📝 `model/models/gptoss/model.go` (+8 -9) 📝 `model/models/llama/model.go` (+7 -6) 📝 `model/models/llama4/model_text.go` (+7 -4) 📝 `model/models/mistral3/model_text.go` (+7 -4) 📝 `model/models/mistral3/model_vision.go` (+4 -4) 📝 `model/models/mllama/model_text.go` (+8 -5) 📝 `model/models/nomicbert/model.go` (+6 -3) 📝 `model/models/qwen2/model.go` (+7 -6) 📝 `model/models/qwen25vl/model_text.go` (+10 -4) 📝 `model/models/qwen25vl/model_vision.go` (+4 -4) 📝 `model/models/qwen3/model.go` (+1 -2) 📝 `model/models/qwen3vl/model.go` (+1 -1) 📝 `model/models/qwen3vl/model_text.go` (+4 -5) _...and 1 more files_ </details> ### 📄 Description change to a flatter directory structure and group the options with the function update models to call rope in one place --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:44:34 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14091