github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 16:40:08 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #12793] [MERGED] create: inherit FROM model's renderer/parser #13952

New Issue
Closed
opened 2026-04-13 00:41:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:41:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12793
Author: @drifkin
Created: 10/27/2025
Status: ✅ Merged
Merged: 10/28/2025
Merged by: @drifkin

Base: main ← Head: drifkin/12792_renderer-parser-from

📝 Commits (1)

  • 1bdd816 create: inherit FROM model's renderer/parser

📊 Changes

2 files changed (+87 additions, -0 deletions)

View changed files

📝 server/create.go (+21 -0)
📝 server/routes_create_test.go (+66 -0)

📄 Description

On main, the RENDERER and PARSER fields from the Modelfile don't get propagated to a new model created with a req.From parameter. This is easily triggered via ollama run qwen3-coder, then running some save command like /save qwen3-coder-custom.

Added a regression test for this, and then open the config for the "from" model in order to use its renderer/parser as a default for the new model. This will fix the CLI and also API-based creates.

Fixes: https://github.com/ollama/ollama/issues/12792

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12793 **Author:** [@drifkin](https://github.com/drifkin) **Created:** 10/27/2025 **Status:** ✅ Merged **Merged:** 10/28/2025 **Merged by:** [@drifkin](https://github.com/drifkin) **Base:** `main` ← **Head:** `drifkin/12792_renderer-parser-from` --- ### 📝 Commits (1) - [`1bdd816`](https://github.com/ollama/ollama/commit/1bdd81691063003e8be5a856942273bd7ca15acd) create: inherit FROM model's renderer/parser ### 📊 Changes **2 files changed** (+87 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/create.go` (+21 -0) 📝 `server/routes_create_test.go` (+66 -0) </details> ### 📄 Description On main, the `RENDERER` and `PARSER` fields from the `Modelfile` don't get propagated to a new model created with a `req.From` parameter. This is easily triggered via `ollama run qwen3-coder`, then running some save command like `/save qwen3-coder-custom`. Added a regression test for this, and then open the config for the "from" model in order to use its renderer/parser as a default for the new model. This will fix the CLI and also API-based creates. Fixes: https://github.com/ollama/ollama/issues/12792 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:41:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13952
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?