[PR #12646] [MERGED] fs(ggml): fill in arch prefix if necessary #13898

Closed
opened 2026-04-13 00:39:45 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12646
Author: @mxyng
Created: 10/16/2025
Status: Merged
Merged: 10/20/2025
Merged by: @mxyng

Base: mainHead: mxyng/convert


📝 Commits (1)

  • 2b26dc7 fs(ggml): fill in arch prefix if necessary

📊 Changes

6 files changed (+82 additions, -54 deletions)

View changed files

📝 convert/convert_test.go (+3 -7)
📝 fs/ggml/gguf.go (+15 -3)
📝 fs/ggml/gguf_test.go (+12 -2)
📝 parser/parser_test.go (+5 -1)
📝 server/routes_create_test.go (+42 -36)
📝 server/routes_delete_test.go (+5 -5)

📄 Description

this change allows conversion kvs to omit the architecture prefix. kvs without a prefix, and not one of general.*, adapter.*, or tokenizer.*, will have general.architecture prepended to it


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12646 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 10/16/2025 **Status:** ✅ Merged **Merged:** 10/20/2025 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/convert` --- ### 📝 Commits (1) - [`2b26dc7`](https://github.com/ollama/ollama/commit/2b26dc7b945bac4a2d047039a0a0b2bd65678620) fs(ggml): fill in arch prefix if necessary ### 📊 Changes **6 files changed** (+82 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `convert/convert_test.go` (+3 -7) 📝 `fs/ggml/gguf.go` (+15 -3) 📝 `fs/ggml/gguf_test.go` (+12 -2) 📝 `parser/parser_test.go` (+5 -1) 📝 `server/routes_create_test.go` (+42 -36) 📝 `server/routes_delete_test.go` (+5 -5) </details> ### 📄 Description this change allows conversion kvs to omit the architecture prefix. kvs without a prefix, and not one of `general.*`, `adapter.*`, or `tokenizer.*`, will have `general.architecture` prepended to it --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:39:45 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13898