github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #12581] [MERGED] routes: fix built-in renderers for api/generate #13879

New Issue
Closed
opened 2026-04-13 00:39:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:39:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12581
Author: @drifkin
Created: 10/11/2025
Status: ✅ Merged
Merged: 10/11/2025
Merged by: @drifkin

Base: main ← Head: drifkin/renderer-api-generate

📝 Commits (1)

  • 6db8da9 routes: fix built-in renderers for api/generate

📊 Changes

3 files changed (+341 additions, -10 deletions)

View changed files

📝 server/routes.go (+27 -9)
📝 server/routes_debug_test.go (+1 -1)
➕ server/routes_generate_renderer_test.go (+313 -0)

📄 Description

Made it so when api/generate builds up a message array and generates the prompt it now goes through the same function as api/chat for consistency. This is where we hook the optional built-in renderers to bypass templates, which was missing for api/generate before this change.

Closes: #12578

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12581 **Author:** [@drifkin](https://github.com/drifkin) **Created:** 10/11/2025 **Status:** ✅ Merged **Merged:** 10/11/2025 **Merged by:** [@drifkin](https://github.com/drifkin) **Base:** `main` ← **Head:** `drifkin/renderer-api-generate` --- ### 📝 Commits (1) - [`6db8da9`](https://github.com/ollama/ollama/commit/6db8da99588de07a49fe788df6b53a7637b21344) routes: fix built-in renderers for `api/generate` ### 📊 Changes **3 files changed** (+341 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `server/routes.go` (+27 -9) 📝 `server/routes_debug_test.go` (+1 -1) ➕ `server/routes_generate_renderer_test.go` (+313 -0) </details> ### 📄 Description Made it so when api/generate builds up a message array and generates the prompt it now goes through the same function as `api/chat` for consistency. This is where we hook the optional built-in renderers to bypass templates, which was missing for `api/generate` before this change. Closes: #12578 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:39:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13879
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?