[PR #12308] [MERGED] fix(llama): other llama flavours #13779

Closed
opened 2026-04-13 00:36:15 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12308
Author: @mxyng
Created: 9/16/2025
Status: Merged
Merged: 9/17/2025
Merged by: @mxyng

Base: mainHead: mxyng/llama


📝 Commits (4)

📊 Changes

10 files changed (+74 additions, -66 deletions)

View changed files

📝 model/models/gemma2/model.go (+3 -3)
📝 model/models/gemma3/model_text.go (+3 -3)
📝 model/models/gemma3n/model_text.go (+4 -4)
📝 model/models/llama/model.go (+40 -32)
📝 model/models/llama4/model_text.go (+4 -4)
📝 model/models/mistral3/model_text.go (+4 -4)
📝 model/models/mllama/model_text.go (+4 -4)
📝 model/models/qwen2/model.go (+4 -4)
📝 model/models/qwen25vl/model_text.go (+4 -4)
📝 model/models/qwen3/model.go (+4 -4)

📄 Description

this change updates the llama model to handle more than the basic llama models. now models with sentencepiece tokenizers will also be supported

this also fixes rope scaling factor for all models to use rope.scaling.factor rather than rope.freq_scale


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12308 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 9/16/2025 **Status:** ✅ Merged **Merged:** 9/17/2025 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/llama` --- ### 📝 Commits (4) - [`5113cd6`](https://github.com/ollama/ollama/commit/5113cd6a0f054b4b099647d84a921e774df8cc3f) fix(llama): rope scale - [`f40b690`](https://github.com/ollama/ollama/commit/f40b690175c0a8b210c3d0d030a70307330219ef) spm llama - [`689e6b0`](https://github.com/ollama/ollama/commit/689e6b046c2da6bba3754893304b232b01152ef0) skip moe models - [`99484ea`](https://github.com/ollama/ollama/commit/99484ead2bb64b768be646f3df09ca98ec7aec06) cleanup ### 📊 Changes **10 files changed** (+74 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `model/models/gemma2/model.go` (+3 -3) 📝 `model/models/gemma3/model_text.go` (+3 -3) 📝 `model/models/gemma3n/model_text.go` (+4 -4) 📝 `model/models/llama/model.go` (+40 -32) 📝 `model/models/llama4/model_text.go` (+4 -4) 📝 `model/models/mistral3/model_text.go` (+4 -4) 📝 `model/models/mllama/model_text.go` (+4 -4) 📝 `model/models/qwen2/model.go` (+4 -4) 📝 `model/models/qwen25vl/model_text.go` (+4 -4) 📝 `model/models/qwen3/model.go` (+4 -4) </details> ### 📄 Description this change updates the llama model to handle more than the basic llama models. now models with sentencepiece tokenizers will also be supported this also fixes rope scaling factor for all models to use `rope.scaling.factor` rather than `rope.freq_scale` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:36:15 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13779