github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 16:40:08 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #11386] tools: find the right tool to call #13525

New Issue
Closed
opened 2026-04-13 00:29:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:29:29 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/ollama/ollama/pull/11386

State: closed
Merged: No

If a tool list has tools in which one is a substring of the other, it's possible for the wrong tool to be selected.

For example, tools=[add, get_ip_address]. If the model generates a tool call for get_ip_address, it's possible for the tool parser to incorrectly select add.

This PR avoids that by locating the earliest and longest matching tool name in the buffer.

Example failure:

#!/usr/bin/env python3

import ollama
import sys

def rm(file):
  """
    Remove a file.
    Args:
      file (str): name of file to remove.
  """
  return True

def format(file):
  """
    Format the contents of file according to the go style guide.
    Args:
      file (str): name of file to be formatted.
  """
  return True

response = ollama.chat(model="devstral", tools=[rm, format],
    messages=[{"role":"user","content":sys.argv[1]}],
    stream=False)

print(response.message.tool_calls)

$ ./11386.py 'format server/routes.go to match the style guide'
[ToolCall(function=Function(name='rm', arguments={'file': 'server/routes.go'}))]
**Original Pull Request:** https://github.com/ollama/ollama/pull/11386 **State:** closed **Merged:** No --- If a tool list has tools in which one is a substring of the other, it's possible for the wrong tool to be selected. For example, tools=[add, get_ip_address]. If the model generates a tool call for `get_ip_address`, it's possible for the tool parser to incorrectly select `add`. This PR avoids that by locating the earliest and longest matching tool name in the buffer. Example failure: ```python #!/usr/bin/env python3 import ollama import sys def rm(file): """ Remove a file. Args: file (str): name of file to remove. """ return True def format(file): """ Format the contents of file according to the go style guide. Args: file (str): name of file to be formatted. """ return True response = ollama.chat(model="devstral", tools=[rm, format], messages=[{"role":"user","content":sys.argv[1]}], stream=False) print(response.message.tool_calls) ``` ```shell $ ./11386.py 'format server/routes.go to match the style guide' [ToolCall(function=Function(name='rm', arguments={'file': 'server/routes.go'}))] ```
GiteaMirror added the pull-request label 2026-04-13 00:29:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13525
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?