github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-08 08:59:13 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #11318] Fix 6932 empty suffix fim #13505

New Issue
Open
opened 2026-04-13 00:29:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:29:02 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/ollama/ollama/pull/11318

State: open
Merged: No

Community Note

  • Please vote on this pull request by adding a 👍 reaction to help prioritize it.
  • Please do not leave "+1" or similar comments to reduce noise.
  • Verified with go test -v -run '^TestGenerateWithEmptySuffix$'.

Affected Endpoint

  • /api/generate

Description

Fixes issue #6932, where the /api/generate endpoint for the qwen2.5-coder:1.5b model fails to exhibit Fill-in-the-Middle (FIM) behavior when suffix is an empty string (""), unlike when it’s a space (" "). This PR modifies the server to treat an empty suffix as a space to trigger FIM, aligning with expected behavior for this model.

Changes

  • Updated server.go (or equivalent) to handle an empty suffix by setting it to a space for qwen2.5-coder:1.5b, ensuring FIM functionality.
  • Added TestGenerateWithEmptySuffix in server_test.go to verify the fix, using a local test server to simulate the API.
**Original Pull Request:** https://github.com/ollama/ollama/pull/11318 **State:** open **Merged:** No --- **Community Note** * Please vote on this pull request by adding a 👍 reaction to help prioritize it. * Please do not leave "+1" or similar comments to reduce noise. * Verified with `go test -v -run '^TestGenerateWithEmptySuffix$'`. **Affected Endpoint** * /api/generate **Description** Fixes issue #6932, where the `/api/generate` endpoint for the `qwen2.5-coder:1.5b` model fails to exhibit Fill-in-the-Middle (FIM) behavior when `suffix` is an empty string (`""`), unlike when it’s a space (`" "`). This PR modifies the server to treat an empty `suffix` as a space to trigger FIM, aligning with expected behavior for this model. **Changes** - Updated `server.go` (or equivalent) to handle an empty `suffix` by setting it to a space for `qwen2.5-coder:1.5b`, ensuring FIM functionality. - Added `TestGenerateWithEmptySuffix` in `server_test.go` to verify the fix, using a local test server to simulate the API.
GiteaMirror added the pull-request label 2026-04-13 00:29:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13505
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?