github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-22 21:51:37 -05:00
Code Issues 16.9k Packages Projects Releases 122 Wiki Activity

[PR #10807] fix: mllama quality #13372

New Issue
Closed
opened 2026-04-13 00:25:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:25:16 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/ollama/ollama/pull/10807

State: closed
Merged: Yes

this change contains a series of fixes for mllama impacting both the model itself and the graph

model changes

  • attn_gate and ffn_gate did not have tanh applied to them
  • attn_q and attn_k tensors for the vision model did not have their attention heads swapped as is tradition for llama models

graph changes

  • during refactoring, ffn_gate was moved out of mllama.VisionMLP into its parent but was not applied in the correct spot
  • remove mllama.VisionSelfAttention.Gate which is unused
  • use nn.Attention
**Original Pull Request:** https://github.com/ollama/ollama/pull/10807 **State:** closed **Merged:** Yes --- this change contains a series of fixes for mllama impacting both the model itself and the graph model changes - `attn_gate` and `ffn_gate` did not have `tanh` applied to them - `attn_q` and `attn_k` tensors for the vision model did not have their attention heads swapped as is tradition for llama models graph changes - during refactoring, ffn_gate was moved out of `mllama.VisionMLP` into its parent but was not applied in the correct spot - remove `mllama.VisionSelfAttention.Gate` which is unused - use `nn.Attention`
GiteaMirror added the pull-request label 2026-04-13 00:25:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13372
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?