github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-23 06:01:37 -05:00
Code Issues 16.9k Packages Projects Releases 122 Wiki Activity

[PR #10447] convert/convert_qwen2: Fix ropescaling factor data type for Qwen2 models #13244

New Issue
Open
opened 2026-04-13 00:21:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:21:54 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/ollama/ollama/pull/10447

State: open
Merged: No

The data type used for rope scaling factor, ropeFactor, is defined in convert_phi3.go as an array of type float32, but ropescaling factor is supposed to be a single float32 (short_factor and long_factor are lists of float32). This fix modifies the data type of the ropescaling factor in the qwen2Model struct to be a float32, which matches what it is in other model specific convert files.

Without this fix, the following error is shown when trying to convert qwen2 based models that have the ropescaling factor in the config.json file. (Such as the openhands models)

Error: json: cannot unmarshal number into Go struct field .rope_scaling.factor of type convert.ropeFactor

**Original Pull Request:** https://github.com/ollama/ollama/pull/10447 **State:** open **Merged:** No --- The data type used for rope scaling factor, `ropeFactor`, is defined in [convert_phi3.go](https://github.com/ollama/ollama/blob/5cfc1c39f3d5822b0c0906f863f6df45c141c33b/convert/convert_phi3.go#L118) as an array of type `float32`, but ropescaling `factor` is supposed to be a single `float32` (`short_factor` and `long_factor` are lists of `float32`). This fix modifies the data type of the ropescaling factor in the `qwen2Model` struct to be a `float32`, which matches what it is in other model specific convert files. Without this fix, the following error is shown when trying to convert qwen2 based models that have the ropescaling factor in the config.json file. (Such as the openhands models) `Error: json: cannot unmarshal number into Go struct field .rope_scaling.factor of type convert.ropeFactor`
GiteaMirror added the pull-request label 2026-04-13 00:21:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13244
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?