github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #10326] [MERGED] server/internal/registry: make pull send errors with Error field #13212

New Issue
Closed
opened 2026-04-13 00:21:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:21:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/10326
Author: @bmizerany
Created: 4/17/2025
Status: ✅ Merged
Merged: 4/19/2025
Merged by: @jmorganca

Base: main ← Head: bmizerany/client2makeerrorserrors

📝 Commits (1)

  • 08a8782 server/internal/registry: make pull send errors with Error field

📊 Changes

2 files changed (+9 additions, -7 deletions)

View changed files

📝 server/internal/registry/server.go (+7 -5)
📝 server/internal/registry/server_test.go (+2 -2)

📄 Description

Previously, the pull handler would send an error message in the Status field, this prevented the client from using the message as a signal to stop. In the case of the "run" command, it would follow the pull with a "show" which would print a nearly identical "not found" message for unresolved models.

Fixes #10307

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/10326 **Author:** [@bmizerany](https://github.com/bmizerany) **Created:** 4/17/2025 **Status:** ✅ Merged **Merged:** 4/19/2025 **Merged by:** [@jmorganca](https://github.com/jmorganca) **Base:** `main` ← **Head:** `bmizerany/client2makeerrorserrors` --- ### 📝 Commits (1) - [`08a8782`](https://github.com/ollama/ollama/commit/08a878297b7b06ea4f21a287607664b8508b4572) server/internal/registry: make pull send errors with Error field ### 📊 Changes **2 files changed** (+9 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `server/internal/registry/server.go` (+7 -5) 📝 `server/internal/registry/server_test.go` (+2 -2) </details> ### 📄 Description Previously, the pull handler would send an error message in the Status field, this prevented the client from using the message as a signal to stop. In the case of the "run" command, it would follow the pull with a "show" which would print a nearly identical "not found" message for unresolved models. Fixes #10307 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:21:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13212
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?