github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #10237] fix: variable substitution and argument passing in build scripts #13186

New Issue
Open
opened 2026-04-13 00:20:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:20:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/10237
Author: @0xsenty
Created: 4/11/2025
Status: 🔄 Open

Base: main ← Head: patch-1

📝 Commits (1)

  • 5fcbb56 fix: variable substitution and argument passing in build scripts

📊 Changes

1 file changed (+15 additions, -15 deletions)

View changed files

📝 scripts/env.sh (+15 -15)

📄 Description

fixed a couple of issues in the build setup:

  • removed unnecessary single quotes around the GOFLAGS string to ensure that the $VERSION variable is correctly substituted.
  • updated the --build-arg arguments to explicitly pass the values of the corresponding variables, rather than just their names.
  • corrected the formatting in OLLAMA_COMMON_BUILD_ARGS to ensure all variables are properly passed with their values.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/10237 **Author:** [@0xsenty](https://github.com/0xsenty) **Created:** 4/11/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`5fcbb56`](https://github.com/ollama/ollama/commit/5fcbb56c16f7ce0a465cbc9b0ce102a44769e930) fix: variable substitution and argument passing in build scripts ### 📊 Changes **1 file changed** (+15 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `scripts/env.sh` (+15 -15) </details> ### 📄 Description fixed a couple of issues in the build setup: - removed unnecessary single quotes around the `GOFLAGS` string to ensure that the `$VERSION` variable is correctly substituted. - updated the `--build-arg` arguments to explicitly pass the values of the corresponding variables, rather than just their names. - corrected the formatting in `OLLAMA_COMMON_BUILD_ARGS` to ensure all variables are properly passed with their values. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:20:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13186
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?